Skip to content

Commit

Permalink
use add_compile_options() rather than adjusting CMAKE_CXX_FLAGS
Browse files Browse the repository at this point in the history
  • Loading branch information
Dan Smith committed Jun 13, 2023
1 parent d5f3477 commit 817cd0c
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions modules/c++/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ elseif (UNIX)
add_compile_options(-std=c++14)

add_compile_options(-Wall -pedantic -Wextra)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wregister") # -Wvolatile
#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Weffc++")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wzero-as-null-pointer-constant")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Woverloaded-virtual")
#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wold-style-cast")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-final-types -Wsuggest-final-methods")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override")
add_compile_options(-Wregister) # -Wregister
#add_compile_options(-Weffc++)

add_compile_options(-Wzero-as-null-pointer-constant)
add_compile_options(-Woverloaded-virtual)
#add_compile_options(-Wold-style-cast)
add_compile_options(-Wsuggest-final-types -Wsuggest-final-methods)
add_compile_options(-Wsuggest-override)
endif()

# add an interface library for unittests
Expand Down

0 comments on commit 817cd0c

Please sign in to comment.