Skip to content

Commit

Permalink
chore(tsx): remove unnecesssary --no-warnings option
Browse files Browse the repository at this point in the history
The warnings that concern us are ignored by tsx:
https://github.com/privatenumber/tsx/blob/28a3e7d2b8fd72b683aab8a98dd1fcee4624e4cb/src/suppress-warnings.cts\#L12

Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
  • Loading branch information
caugner and queengooborg committed Jan 9, 2025
1 parent 5ec5f12 commit 081718b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 17 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/add-push-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
node-version-file: ".nvmrc"
cache: npm
- run: npm ci
- run: npx tsx --no-warnings=ExperimentalWarning ./scripts/enumerate-features.ts features.json
- run: npx tsx --no-warnings=ExperimentalWarning ./scripts/diff-features.ts --no-github --format=json > features.diff.json
- run: npx tsx ./scripts/enumerate-features.ts features.json
- run: npx tsx ./scripts/diff-features.ts --no-github --format=json > features.diff.json
- uses: actions/upload-artifact@v4
with:
name: enumerate-features
Expand Down
24 changes: 12 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,25 +94,25 @@
},
"scripts": {
"postinstall": "(git rev-parse --is-inside-work-tree && npm run save-git-history) || echo 'not in Git worktree; skipping save-git-history'",
"save-git-history": "tsx --no-warnings=ExperimentalWarning scripts/save-git-history.ts",
"save-git-history": "tsx scripts/save-git-history.ts",
"prepare": "(husky || true) && npm run gentypes && npm run build",
"diff": "tsx --no-warnings=ExperimentalWarning scripts/diff.ts",
"diff": "tsx scripts/diff.ts",
"unittest": "NODE_ENV=test c8 mocha index.test.ts --require tsx --recursive \"{,!(node_modules)/**}/*.test.ts\"",
"coverage": "c8 report -r lcov && open-cli coverage/lcov-report/index.html",
"format": "eslint . && prettier --check . && tsc --noEmit",
"format:fix": "eslint --quiet --fix . && prettier --write .",
"lint": "tsx --no-warnings=ExperimentalWarning lint/lint.ts",
"lint:fix": "tsx --no-warnings=ExperimentalWarning lint/fix.ts",
"lint": "tsx lint/lint.ts",
"lint:fix": "tsx lint/fix.ts",
"fix": "npm run format:fix && npm run lint:fix",
"stats": "tsx --no-warnings=ExperimentalWarning scripts/statistics.ts",
"build": "tsx --no-warnings=ExperimentalWarning scripts/build/index.ts",
"gentypes": "tsx --no-warnings=ExperimentalWarning scripts/generate-types.ts",
"release": "tsx --no-warnings=ExperimentalWarning scripts/release/index.ts",
"remove-redundant-flags": "tsx --no-warnings=ExperimentalWarning scripts/remove-redundant-flags.ts",
"stats": "tsx scripts/statistics.ts",
"build": "tsx scripts/build/index.ts",
"gentypes": "tsx scripts/generate-types.ts",
"release": "tsx scripts/release/index.ts",
"remove-redundant-flags": "tsx scripts/remove-redundant-flags.ts",
"show-errors": "npm test 1> /dev/null",
"test": "npm run format && npm run lint && npm run unittest",
"traverse": "tsx --no-warnings=ExperimentalWarning scripts/traverse.ts",
"update-browser-releases": "tsx --no-warnings=ExperimentalWarning scripts/update-browser-releases/index.ts",
"bcd": "tsx --no-warnings=ExperimentalWarning scripts/bulk-editor/index.ts"
"traverse": "tsx scripts/traverse.ts",
"update-browser-releases": "tsx scripts/update-browser-releases/index.ts",
"bcd": "tsx scripts/bulk-editor/index.ts"
}
}
4 changes: 1 addition & 3 deletions scripts/diff-features.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,7 @@ const enumerateFeatures = (ref = 'HEAD', quiet = false): string[] => {
// If the clean install fails, proceed anyways
}

execSync(
`npx tsx --no-warnings=ExperimentalWarning ./scripts/enumerate-features.ts --data-from=${worktree}`,
);
execSync(`npx tsx ./scripts/enumerate-features.ts --data-from=${worktree}`);

return JSON.parse(fs.readFileSync('.features.json', { encoding: 'utf-8' }));
} finally {
Expand Down

0 comments on commit 081718b

Please sign in to comment.