Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flags from webview_android #4609

Closed
1 of 24 tasks
bershanskiy opened this issue Aug 13, 2019 · 6 comments
Closed
1 of 24 tasks

Remove flags from webview_android #4609

bershanskiy opened this issue Aug 13, 2019 · 6 comments
Labels
bulk_update An update to a mass amount of data, or scripts/linters related to such changes enhancement Nice to have features. schema Isses or pull requests regarding the JSON schema files used in this project.
Milestone
Migration 002: Re...

Comments

@bershanskiy
Copy link
Contributor

bershanskiy commented Aug 13, 2019 •
edited by queengooborg
Loading

Summary

As came up a few times in conversation, Android Webview does not have the ability to set flags so the flags attribute in the compatibility data is useless. We should remove flags from data first and then eventually remove it from the schema.

Details

Remove flags from webview_android schema

Patch schemas/compat-data.schema.json to remove flags. I already made a simple patch which I'll share soon.

Remove flags from webview_android data

I edited the schema and this is that was logged (should probably fix before :

  • api/AuthenticationAssertion.json
  • api/Headers.json
  • api/MediaCapabilities.json
  • api/Navigator.json
  • api/OffscreenCanvas.json
  • api/PaymentCurrencyAmount.json
  • api/Response.json
  • api/ScopedCredential.json
  • api/ScopedCredentialInfo.json
  • api/VideoTrackList.json
  • api/WebAuthentication.json
  • api/Window.json
  • css/properties/color.json
  • css/properties/column-gap.json
  • css/properties/font-size-adjust.json
  • css/properties/grid-column-start.json
  • css/properties/grid-column.json
  • css/properties/line-height-step.json
  • css/properties/text-align-last.json
  • css/types/image.json
  • html/elements/img.json
  • html/elements/video.json
  • html/global_attributes.json
  • http/headers/feature-policy.json
@queengooborg queengooborg added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP enhancement Nice to have features. schema Isses or pull requests regarding the JSON schema files used in this project. labels Aug 14, 2019
@queengooborg
Copy link
Contributor

Thank you for taking the time to dig down into this one! Yes, we should definitely remove all entries with flags in them for WebView Android. Perhaps a linter test may also be reasonable to include, as so to reduce human error during the review process. Thoughts?

@Elchi3
Copy link
Member

Elchi3 commented Aug 14, 2019

I think this should follow the bulk change process which were are currently defining.

@queengooborg queengooborg added bulk_update An update to a mass amount of data, or scripts/linters related to such changes and removed data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP labels Aug 14, 2019
@bershanskiy
Copy link
Contributor Author

FYI: I made a commit (also linked above) that fixes this. It's just a draft at this point so I haven't opened a PR.

Perhaps a linter test may also be reasonable to include

I had changed the data schema to disallow webview_android to have flags so this is already covered by test/test-schema.js.

I think this should follow the bulk change process which were are currently defining.

Definitely. That is tracked in #4469, right?

@queengooborg queengooborg mentioned this issue Aug 29, 2019
Merged
@queengooborg
Copy link
Contributor

After a little more research, I found out that Samsung Internet doesn't have flags either. It might be a good idea to expand the scope of this to also encompass Samsung Internet! Thoughts?

@Elchi3
Copy link
Member

Elchi3 commented Sep 2, 2019

Can you file a separate issue for that? We can then cc Samsung folks there and get it approved / done separately.

@queengooborg queengooborg mentioned this issue Sep 2, 2019
Closed
@queengooborg queengooborg mentioned this issue Nov 18, 2019
Merged
@queengooborg
Copy link
Contributor

And we’re all done here, woo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bulk_update An update to a mass amount of data, or scripts/linters related to such changes enhancement Nice to have features. schema Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Milestone
Migration 002: Remove WebView Flags
Development

No branches or pull requests
3 participants
@Elchi3 @queengooborg @bershanskiy