Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration 002: Prevent WebView entries from containing flags #5148

Merged
merged 3 commits into from
Nov 29, 2019
Merged

Migration 002: Prevent WebView entries from containing flags #5148

merged 3 commits into from
Nov 29, 2019

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Nov 18, 2019 •
edited
Loading

This PR introduces the linter to finish up #4609.

@queengooborg queengooborg requested a review from Elchi3 as a code owner November 18, 2019 13:53
@ghost ghost added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Nov 18, 2019
ddbeck
ddbeck requested changes Nov 25, 2019
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion here. Thanks!

Elchi3
Elchi3 approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can land now, no?
r+ on the change

@queengooborg
Copy link
Contributor Author

We’ve got everything merged for this one, so I’d say this is ready to go, yeah!

@Elchi3 Elchi3 merged commit edbbaae into mdn:master Nov 29, 2019
@queengooborg queengooborg deleted the migrations/002-linter branch November 29, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck requested changes

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Milestone
Migration 002: Remove WebView Flags
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @ddbeck @Elchi3