Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chrome/Safari versions for api.HTMLInputElement.search_event #11755

Merged

Conversation

queengooborg
Copy link
Contributor

This PR adds real values for Chrome and Safari for the search_event member of the HTMLInputElement API. The data was copied from its event handler counterparts.

This PR adds real values for Chrome and Safari for the `search_event` member of the `HTMLInputElement` API.  The data was copied from its event handler counterparts.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 25, 2021
@foolip
Copy link
Contributor

foolip commented Jul 30, 2021

Can you test this? I wonder if there are multiple "search" events and if it's actually fired going back to Safari 1. I find it suspicious that Edge wouldn't have supported this if it's that old.

@gsnedders
Copy link
Contributor

Can you test this? I wonder if there are multiple "search" events and if it's actually fired going back to Safari 1. I find it suspicious that Edge wouldn't have supported this if it's that old.

My exceptionally distant memory is that the search stuff came alongside Tiger, which implies earlier didn't support it?

@foolip
Copy link
Contributor

foolip commented Aug 26, 2021

Thanks @gsnedders! Tiger would mean Safari 2, and this led me to notice that maybe Safari 1.3 is a backport, I've commented in #11909 (comment).

Here I think we should go with Safari 2, trusting @gsnedders' distant memory, rather than trying to determine for sure if it worked in 1.3.

@foolip foolip merged commit b98ef8e into mdn:main Aug 30, 2021
@queengooborg queengooborg deleted the api/HTMLInputElement/search_event/webkit branch August 30, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants