-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MediaKeySystemConfiguration API from BCD #12840
Merged
ddbeck
merged 4 commits into
mdn:main
from
queengooborg:api/MediaKeySystemConfiguration/removal
Dec 29, 2021
Merged
Remove MediaKeySystemConfiguration API from BCD #12840
ddbeck
merged 4 commits into
mdn:main
from
queengooborg:api/MediaKeySystemConfiguration/removal
Dec 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes `MediaKeySystemConfiguration` from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.
This was referenced Oct 14, 2021
foolip
reviewed
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dictionary is also used in requestMediaKeySystemAccess()
. Is some change there warranted?
ddbeck
reviewed
Dec 2, 2021
a9ea03c
to
b5e1522
Compare
ddbeck
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you! 🎉
Swansoffie02
added a commit
to Swansoffie02/browser-compat-data
that referenced
this pull request
Jan 1, 2022
This reverts commit 8807bad.
jpmedley
pushed a commit
that referenced
this pull request
Jan 10, 2022
* Remove MediaKeySystemConfiguration API from BCD This PR removes `MediaKeySystemConfiguration` from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD. * Fold Firefox data into notes * Update wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
MediaKeySystemConfiguration
from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.