Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MediaKeySystemConfiguration API from BCD #12840

Merged
merged 4 commits into from
Dec 29, 2021

Conversation

queengooborg
Copy link
Contributor

This PR removes MediaKeySystemConfiguration from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.

This PR removes `MediaKeySystemConfiguration` from BCD.  This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.
@queengooborg queengooborg added needs-release-note 📰 needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Oct 13, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 13, 2021
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Oct 15, 2021
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dictionary is also used in requestMediaKeySystemAccess(). Is some change there warranted?

@queengooborg queengooborg force-pushed the api/MediaKeySystemConfiguration/removal branch from a9ea03c to b5e1522 Compare December 15, 2021 10:31
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🎉

@ddbeck ddbeck merged commit 8807bad into mdn:main Dec 29, 2021
@queengooborg queengooborg deleted the api/MediaKeySystemConfiguration/removal branch December 29, 2021 13:07
Swansoffie02 added a commit to Swansoffie02/browser-compat-data that referenced this pull request Jan 1, 2022
jpmedley pushed a commit that referenced this pull request Jan 10, 2022
* Remove MediaKeySystemConfiguration API from BCD

This PR removes `MediaKeySystemConfiguration` from BCD.  This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.

* Fold Firefox data into notes

* Update wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants