Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chromium versions for api.Response.Response.body_param_null #13076

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Add Chromium versions for api.Response.Response.body_param_null #13076

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac13257
Add Chromium versions for api.Response.Response.body_param_null
queengooborg Oct 24, 2021
d8db63f
Fix dates
queengooborg Oct 26, 2021
e27d651
Revert "Fix dates" (date was before Response API)
queengooborg Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions api/Response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,15 @@
}
}
},
"body_param_null": {
"body_parameter_optional": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My knowledge of BCD has obviously gotten out of date. Would you mind sending me an explanation of how this resolves to the key on the MDN page (browser-compat: api.Response.body) when there's no part of the JSON tree named "body"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't resolve to api.Response.body. This key is talking about the body parameter passed into the Response() constructor!

"__compat": {
"description": "body parameter can be <code>null</code>",
"description": "<code>body</code> parameter is optional",
"support": {
"chrome": {
"version_added": true
"version_added": "40"
},
"chrome_android": {
"version_added": true
"version_added": "40"
},
"deno": {
"version_added": "1.0"
Expand All @@ -220,10 +220,10 @@
"version_added": false
},
"opera": {
"version_added": true
"version_added": "29"
},
"opera_android": {
"version_added": true
"version_added": "29"
},
"safari": {
"version_added": false
Expand All @@ -232,10 +232,10 @@
"version_added": false
},
"samsunginternet_android": {
"version_added": true
"version_added": "4.0"
},
"webview_android": {
"version_added": true
"version_added": "40"
}
},
"status": {
Expand Down