Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edge versions for api.RTCIceCandidate.address #13743

Merged

Conversation

queengooborg
Copy link
Contributor

This PR adds real values for Microsoft Edge for the address member of the RTCIceCandidate API, based upon manual testing.

Test Code Used: var rtcic = new RTCIceCandidate(); rtcic.ip;

This PR adds real values for Microsoft Edge for the `address` member of the `RTCIceCandidate` API, based upon manual testing.

Test Code Used: `var rtcic = new RTCIceCandidate(); rtcic.ip;`
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 26, 2021
@foolip
Copy link
Contributor

foolip commented Nov 29, 2021

So the ip property was never there? Can you check where this data came from?

@queengooborg
Copy link
Contributor Author

It looks like the data for the ip feature/alt. name originally came from the wiki migration. It was originally added with everything set to true, which further makes me think that it's incorrect.

@foolip
Copy link
Contributor

foolip commented Nov 29, 2021

Alright, maybe it was for some other interface that provided similar functionality. Edge had a rather different variant of WebRTC called ORTC, after all.

@foolip foolip merged commit c1a40c8 into mdn:main Nov 29, 2021
@queengooborg queengooborg deleted the api/RTCIceCandidate/address/edge-corrections branch November 29, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants