Fix Chromium data for devicemotion event interfaces #14445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was all added in WebKit trunk 534.5 and 534.9: https://trac.webkit.org/changeset/64845/webkit https://trac.webkit.org/changeset/68252/webkit It wasn't enabled then, but because it all went together, it can all be assumed to match the ondevicemotion property being exposed. That was confirmed to be Chrome 31 with this test: http://mdn-bcd-collector.appspot.com/tests/api/Window/ondevicemotion The source of Chrome 11 is here: mdn#5834 The description says Chrome 31, so this must have been a copy-paste error from the IE version. Also update the Samsung Internet and WebView versions based on conservative mirroring. It's possible this was supported earlier, but the current version numbers also seem to be based on mirroring, not testing: mdn#6838
github-actions
bot
added
the
data:api
queengooborg
approved these changes
Jan 8, 2022
jpmedley
pushed a commit
that referenced
this pull request
Jan 10, 2022
This was all added in WebKit trunk 534.5 and 534.9: https://trac.webkit.org/changeset/64845/webkit https://trac.webkit.org/changeset/68252/webkit It wasn't enabled then, but because it all went together, it can all be assumed to match the ondevicemotion property being exposed. That was confirmed to be Chrome 31 with this test: http://mdn-bcd-collector.appspot.com/tests/api/Window/ondevicemotion The source of Chrome 11 is here: #5834 The description says Chrome 31, so this must have been a copy-paste error from the IE version. Also update the Samsung Internet and WebView versions based on conservative mirroring. It's possible this was supported earlier, but the current version numbers also seem to be based on mirroring, not testing: #6838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was all added in WebKit trunk 534.5 and 534.9:
https://trac.webkit.org/changeset/64845/webkit
https://trac.webkit.org/changeset/68252/webkit
It wasn't enabled then, but because it all went together, it can all be
assumed to match the ondevicemotion property being exposed. That was
confirmed to be Chrome 31 with this test:
http://mdn-bcd-collector.appspot.com/tests/api/Window/ondevicemotion
The source of Chrome 11 is here:
#5834
The description says Chrome 31, so this must have been a copy-paste
error from the IE version.
Also update the Samsung Internet and WebView versions based on
conservative mirroring. It's possible this was supported earlier, but
the current version numbers also seem to be based on mirroring, not
testing:
#6838