Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Worker/Message API to new events structure #15046

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Adapt Worker/Message API to new events structure #15046

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d4e822
Adapt DedicatedWorkerGlobalScope API to new events structure
queengooborg Feb 19, 2022
3abb469
Apply updates to related APIs
queengooborg Feb 20, 2022
7ce2be8
Add messageerror_event to ServiceWorkerContainer
queengooborg Mar 2, 2022
8fc6794
Fix sorting
queengooborg Mar 2, 2022
914427b
Merge branch 'main' into api/DedicatedWorkerGlobalScope/events
queengooborg Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 8 additions & 108 deletions api/DedicatedWorkerGlobalScope.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,10 @@
"__compat": {
"description": "<code>message</code> event",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DedicatedWorkerGlobalScope/message_event",
"spec_url": "https://html.spec.whatwg.org/multipage/indices.html#event-message",
"spec_url": [
"https://html.spec.whatwg.org/multipage/indices.html#event-message",
"https://html.spec.whatwg.org/multipage/workers.html#handler-dedicatedworkerglobalscope-onmessage"
],
"support": {
"chrome": {
"version_added": "4"
Expand Down Expand Up @@ -208,7 +211,10 @@
"__compat": {
"description": "<code>messageerror</code> event",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DedicatedWorkerGlobalScope/messageerror_event",
"spec_url": "https://html.spec.whatwg.org/multipage/indices.html#event-messageerror",
"spec_url": [
"https://html.spec.whatwg.org/multipage/indices.html#event-messageerror",
"https://html.spec.whatwg.org/multipage/workers.html#handler-dedicatedworkerglobalscope-onmessageerror"
],
"support": {
"chrome": {
"version_added": "60"
Expand Down Expand Up @@ -311,112 +317,6 @@
}
}
},
"onmessage": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DedicatedWorkerGlobalScope/onmessage",
"spec_url": "https://html.spec.whatwg.org/multipage/workers.html#handler-dedicatedworkerglobalscope-onmessage",
"support": {
"chrome": {
"version_added": "4"
},
"chrome_android": {
"version_added": "18"
},
"deno": {
"version_added": "1.0"
},
"edge": {
"version_added": "12"
},
"firefox": {
"version_added": "3.5"
},
"firefox_android": {
"version_added": "4"
},
"ie": {
"version_added": "10"
},
"opera": {
"version_added": "10.6"
},
"opera_android": {
"version_added": "11"
},
"safari": {
"version_added": "4"
},
"safari_ios": {
"version_added": "5"
},
"samsunginternet_android": {
"version_added": "1.0"
},
"webview_android": {
"version_added": "4.4"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"onmessageerror": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DedicatedWorkerGlobalScope/onmessageerror",
"spec_url": "https://html.spec.whatwg.org/multipage/workers.html#handler-dedicatedworkerglobalscope-onmessageerror",
"support": {
"chrome": {
"version_added": "60"
},
"chrome_android": {
"version_added": "60"
},
"deno": {
"version_added": "1.0"
},
"edge": {
"version_added": "18"
},
"firefox": {
"version_added": "57"
},
"firefox_android": {
"version_added": "57"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "47"
},
"opera_android": {
"version_added": "44"
},
"safari": {
"version_added": false,
"notes": "See <a href='https://webkit.org/b/171216'>bug 171216</a>."
},
"safari_ios": {
"version_added": false,
"notes": "See <a href='https://webkit.org/b/171216'>bug 171216</a>."
},
"samsunginternet_android": {
"version_added": "8.0"
},
"webview_android": {
"version_added": "60"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"postMessage": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DedicatedWorkerGlobalScope/postMessage",
Expand Down
109 changes: 0 additions & 109 deletions api/ServiceWorkerContainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,115 +350,6 @@
}
}
},
"onmessage": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/ServiceWorkerContainer/onmessage",
"spec_url": "https://w3c.github.io/ServiceWorker/#dom-serviceworkerglobalscope-onmessage",
"support": {
"chrome": {
"version_added": "40"
},
"chrome_android": {
"version_added": "40"
},
"edge": {
"version_added": "17"
},
"firefox": {
"version_added": "44",
"notes": "<a href='https://www.mozilla.org/en-US/firefox/organizations/'>Extended Support Releases (ESR)</a> before Firefox 78 ESR do not support service workers and the Push API."
},
"firefox_android": {
"version_added": "44"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "27"
},
"opera_android": {
"version_added": "27"
},
"safari": {
"version_added": "11.1"
},
"safari_ios": {
"version_added": "11.3"
},
"samsunginternet_android": {
"version_added": "4.0"
},
"webview_android": {
"version_added": "40"
}
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
},
"onmessageerror": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/ServiceWorkerContainer/onmessageerror",
"spec_url": "https://w3c.github.io/ServiceWorker/#dom-serviceworkerglobalscope-onmessageerror",
"support": {
"chrome": {
"version_added": "80"
},
"chrome_android": {
"version_added": "80"
},
"edge": [
{
"version_added": "80"
},
{
"version_added": "17",
"version_removed": "79"
}
],
"firefox": {
"version_added": "65"
},
"firefox_android": {
"version_added": "65"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "67"
},
"opera_android": {
"version_added": "57"
},
"safari": {
"version_added": "11.1",
"partial_implementation": true,
"notes": "Although the <code>onmessageerror</code> property is supported, the <code>messageerror</code> event is never fired. See <a href='https://webkit.org/b/171216'>bug 171216</a>."
},
"safari_ios": {
"version_added": "11.3",
"partial_implementation": true,
"notes": "Although the <code>onmessageerror</code> property is supported, the <code>messageerror</code> event is never fired. See <a href='https://webkit.org/b/171216'>bug 171216</a>."
},
"samsunginternet_android": {
"version_added": "13.0"
},
"webview_android": {
"version_added": "80"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"ready": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/ServiceWorkerContainer/ready",
Expand Down
10 changes: 8 additions & 2 deletions api/Window.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3437,7 +3437,10 @@
"__compat": {
"description": "<code>message</code> event",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Window/message_event",
"spec_url": "https://html.spec.whatwg.org/multipage/indices.html#event-message",
"spec_url": [
"https://html.spec.whatwg.org/multipage/indices.html#event-message",
"https://html.spec.whatwg.org/multipage/webappapis.html#handler-window-onmessage"
],
"support": {
"chrome": {
"version_added": "60"
Expand Down Expand Up @@ -3487,7 +3490,10 @@
"__compat": {
"description": "<code>messageerror</code> event",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Window/messageerror_event",
"spec_url": "https://html.spec.whatwg.org/multipage/indices.html#event-messageerror",
"spec_url": [
"https://html.spec.whatwg.org/multipage/indices.html#event-messageerror",
"https://html.spec.whatwg.org/multipage/webappapis.html#handler-window-onmessageerror"
],
"support": {
"chrome": {
"version_added": "60"
Expand Down
100 changes: 0 additions & 100 deletions api/WindowEventHandlers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,106 +293,6 @@
}
}
},
"onmessage": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another case where I'm not sure where this data went. What feature does this map to? Or if it doesn't exist, why isn't it added, based on this?

(My hunch here is that this PR is both demixing and consolidating events, but that's rather difficult to understand and verify from the diff alone.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the WindowEventHandlers mixin, they have been merged into Window!

"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/WindowEventHandlers/onmessage",
"spec_url": "https://html.spec.whatwg.org/multipage/webappapis.html#handler-window-onmessage",
"support": {
"chrome": {
"version_added": "60"
},
"chrome_android": {
"version_added": "60"
},
"edge": {
"version_added": "12"
},
"firefox": {
"version_added": "9"
},
"firefox_android": {
"version_added": "9"
},
"ie": {
"version_added": "8"
},
"opera": {
"version_added": "47"
},
"opera_android": {
"version_added": "44"
},
"safari": {
"version_added": "4"
},
"safari_ios": {
"version_added": "4"
},
"samsunginternet_android": {
"version_added": "8.0"
},
"webview_android": {
"version_added": "60"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"onmessageerror": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/WindowEventHandlers/onmessageerror",
"spec_url": "https://html.spec.whatwg.org/multipage/webappapis.html#handler-window-onmessageerror",
"support": {
"chrome": {
"version_added": "60"
},
"chrome_android": {
"version_added": "60"
},
"edge": {
"version_added": "18"
},
"firefox": {
"version_added": "57"
},
"firefox_android": {
"version_added": "57"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "47"
},
"opera_android": {
"version_added": "44"
},
"safari": {
"version_added": false,
"notes": "See <a href='https://webkit.org/b/171216'>bug 171216</a>."
},
"safari_ios": {
"version_added": false,
"notes": "See <a href='https://webkit.org/b/171216'>bug 171216</a>."
},
"samsunginternet_android": {
"version_added": "8.0"
},
"webview_android": {
"version_added": "60"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"onoffline": {
"__compat": {
"spec_url": "https://html.spec.whatwg.org/multipage/webappapis.html#handler-window-onoffline",
Expand Down
Loading