Remove WindowEventHandlers mixin; remove duplicate event content attributes on <body> #15477

queengooborg · 2022-03-22T20:26:54Z

This PR removes the WindowEventHandlers mixin. The events are placed in Window.json already.

The HTMLBodyElement, HTMLFrameSetElement, and SVGSVGElement interfaces contain the event handler properties as aliases but they are targeted on the window object.

Further, the event content attributes are removed from the HTML body element data to avoid duplication.

foolip · 2022-03-28T13:13:18Z

I think we should have just a single entry per event here, in Window.idl. Although there are event handler properties in other places, there's just one event. The properties on the other interfaces are a kind of aliases, see this example:

<!DOCTYPE html>
<body>
<script>
var handler = function(){};
window.onhashchange = handler;
alert(document.body.onhashchange == handler); // true
</script>

I think the documentation for these events could mention that it's possible to listen for these events via those other interfaces, and BCD could use partial_implementation if any of the ways aren't supported, but separate entries don't make sense to me.

teoli2003 · 2022-03-28T14:24:14Z

From the mdn/content perspective, I think we should

Have one entry at the topmost possible place (likely Window) redirect.
Have a redirect for onXYZ to the XYZ_event on Window.
For each interface (let's call it IF) it can be thrown at or is bubbling through, we should:

have a redirect from IF.onXYZ to Window.XYZ_event
have a redirect from IF.XYZ_event to Window.XYZ_event
Have a text on each interface page, under Events that the global (or another term) can be caught on such element (with a link to the section of Window or the page where they are listed and explained.

That way we achieve:

no duplication of content
no surprise any combination of interface.XYZ_event or interface.onXYZ that does exist leads to the correct page.
information about all events of a specific object on its interface page.

We can likely have a script to check for redirects and be sure not to forget one.

Elchi3 · 2022-03-31T14:59:28Z

mdn/content#14515 is an example PR that does what Philip proposed above. I think it makes sense. This way, we just need data in Window.json and we can use partial_implementation when there are issues in any of the other interfaces.

Elchi3 · 2022-04-04T14:27:14Z

The discussion and proof of concept in mdn/content#14515 was successful. There is a single page for the hashchange event under Window now. The HTMLBodyElement, HTMLFrameSetElement, and SVGSVGElement interface pages list the events but link to the docs under Window.

I will start to work on making the same update for the other events.

In the meantime, this PR needs to change: The events should only appear in Window.json. WindowEventHandlers.json should be removed and no new files in _mixins should be added.

Elchi3 · 2022-04-04T15:15:32Z

One more thing: Remove on- event content attributes from https://github.com/mdn/browser-compat-data/blob/main/html/elements/body.json

Elchi3 · 2022-04-04T15:27:47Z

I've updated the title and description of this PR.

@foolip could you take a look again?

foolip · 2022-04-04T17:42:21Z

This now removes lots of stuff, but are all of these events correctly represented in Window.json, every single one?

queengooborg · 2022-04-04T18:31:29Z

They are, yes -- I double-checked by originally creating a WindowEventHandlers__Window.json mixin and checking for duplicates. All events were accounted for!

foolip · 2022-04-05T05:12:50Z

All right then! And how about the versions, is all data exactly the same, no differences to account for?

queengooborg · 2022-04-05T12:00:25Z

There are some version number differences between the two, but I had looked through the commit history and confirmed that the differences are due to updates that have been made after testing (mostly by myself), as well as spec URL differences and some status changes. I'll be copying over the spec URLs now!

foolip · 2022-04-05T16:01:56Z

Alright, thanks for the extra checks!

queengooborg · 2022-04-07T17:24:24Z

I'm marking this as a draft because there is some inaccurate flag data in this mixin that I'd like to get removed first before this is merged.

Elchi3 · 2022-04-22T12:35:19Z

I made all the content updates on MDN for all WindowEventHandlers events and I opened mdn/content#15246 to remove the WindowEventHandlers mixin page from MDN altogether. It would be good to get this in.

Elchi3 · 2022-04-25T07:22:54Z

I'm marking this as a draft because there is some inaccurate flag data in this mixin that I'd like to get removed first before this is merged.

Is this done or can it be a follow-up?

queengooborg · 2022-04-25T22:48:31Z

The flag data has mostly been taken care of! I'm leaving this marked as a draft though because I probably need to recreate it, or like GlobalEventHandlers, it'd probably be better to update events one by one.

Elchi3

Okay, as you like. I'm r+ on this PR, though.
I'm quite happy with how WindowEventHandlers is represented on MDN now and with this PR in BCD.

queengooborg · 2022-04-26T17:12:14Z

I looked this PR over again and I realize that this is really just adding spec URLs to the existing events on the Window interface, so no need to recreate this PR or anything!

queengooborg added 4 commits March 22, 2022 12:53

Separate WindowEventHandlers mixin into individual files

2027ecc

Convert event handlers to events

219e06d

De-dupe data

117d299

Add missing descriptions

c0cc179

queengooborg added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Mar 22, 2022

queengooborg mentioned this pull request Mar 22, 2022

Update event features according new data guideline #14578

Closed

Elchi3 mentioned this pull request Mar 23, 2022

Delete api.HTMLFrameSetElement.onstorage #15158

Merged

queengooborg mentioned this pull request Mar 23, 2022

Throw a better-worded error when duplicate features found #15479

Merged

Elchi3 mentioned this pull request Mar 28, 2022

Reorganize GlobalEventHandlers and WindowEventHandlers mixin data #12290

Closed

queengooborg mentioned this pull request Mar 30, 2022

api.HTMLFrameSetElement - Inherits the WindowEventHandlers mixin #11675

Closed

Elchi3 mentioned this pull request Mar 31, 2022

Update hashchange event to new structure mdn/content#14515

Merged

Remove mixin files

9bfec88

Remove event handlers from body HTML element

d4ad2c9

github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Apr 4, 2022

Elchi3 changed the title ~~Demix WindowEventHandlers; adapt to new events structure~~ Remove WindowEventHandlers mixin; remove duplicate event content attributes on <body> Apr 4, 2022

Elchi3 requested a review from foolip April 4, 2022 15:27

queengooborg added 2 commits April 5, 2022 05:06

Copy spec URLs from WindowEventHandlers to Window

a1859a2

Merge branch 'main' into api/WindowEventHandlers

e4113e6

foolip approved these changes Apr 5, 2022

View reviewed changes

queengooborg marked this pull request as draft April 7, 2022 17:24

queengooborg added the rebase needed 🚧 label Apr 19, 2022

Elchi3 removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Apr 22, 2022

Merge branch 'main' into api/WindowEventHandlers

360dbfc

queengooborg removed the rebase needed 🚧 label Apr 25, 2022

Elchi3 approved these changes Apr 26, 2022

View reviewed changes

queengooborg marked this pull request as ready for review April 26, 2022 17:11

Elchi3 merged commit 682aaf3 into mdn:main Apr 27, 2022

queengooborg deleted the api/WindowEventHandlers branch April 27, 2022 14:04

queengooborg mentioned this pull request Apr 27, 2022

Remove event handlers from HTML body element (duplicates) #16021

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove WindowEventHandlers mixin; remove duplicate event content attributes on <body> #15477

Remove WindowEventHandlers mixin; remove duplicate event content attributes on <body> #15477

queengooborg commented Mar 22, 2022 •

edited by Elchi3

Loading

foolip commented Mar 28, 2022

teoli2003 commented Mar 28, 2022 •

edited

Loading

Elchi3 commented Mar 31, 2022

Elchi3 commented Apr 4, 2022

Elchi3 commented Apr 4, 2022

Elchi3 commented Apr 4, 2022

foolip commented Apr 4, 2022

queengooborg commented Apr 4, 2022

foolip commented Apr 5, 2022

queengooborg commented Apr 5, 2022

foolip commented Apr 5, 2022

queengooborg commented Apr 7, 2022

Elchi3 commented Apr 22, 2022 •

edited

Loading

Elchi3 commented Apr 25, 2022

queengooborg commented Apr 25, 2022

Elchi3 left a comment

queengooborg commented Apr 26, 2022

Remove WindowEventHandlers mixin; remove duplicate event content attributes on <body> #15477

Remove WindowEventHandlers mixin; remove duplicate event content attributes on <body> #15477

Conversation

queengooborg commented Mar 22, 2022 • edited by Elchi3 Loading

foolip commented Mar 28, 2022

teoli2003 commented Mar 28, 2022 • edited Loading

Elchi3 commented Mar 31, 2022

Elchi3 commented Apr 4, 2022

Elchi3 commented Apr 4, 2022

Elchi3 commented Apr 4, 2022

foolip commented Apr 4, 2022

queengooborg commented Apr 4, 2022

foolip commented Apr 5, 2022

queengooborg commented Apr 5, 2022

foolip commented Apr 5, 2022

queengooborg commented Apr 7, 2022

Elchi3 commented Apr 22, 2022 • edited Loading

Elchi3 commented Apr 25, 2022

queengooborg commented Apr 25, 2022

Elchi3 left a comment

Choose a reason for hiding this comment

queengooborg commented Apr 26, 2022

queengooborg commented Mar 22, 2022 •

edited by Elchi3

Loading

teoli2003 commented Mar 28, 2022 •

edited

Loading

Elchi3 commented Apr 22, 2022 •

edited

Loading