Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Package data for NPM as ESM and CJS" #15774

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Apr 12, 2022

Summary

This reverts #12169 (b740c60), which adds ESM support to the published package.

The change was characterized in the PR as semver major, which landed without owner consensus (clarified in #15738), so it's not ready to ship just yet.

After this lands, I'll open a PR to revert the revert, so this work isn't lost.

Related issues

This reverts commit b740c60.

This change is semver major and I'm not prepared to do that this week.
@github-actions github-actions bot added docs Issues or pull requests regarding the documentation of this project. scripts Issues or pull requests regarding the scripts in scripts/. labels Apr 12, 2022
@ddbeck ddbeck mentioned this pull request Apr 12, 2022
@ddbeck ddbeck merged commit 6f3a8b7 into mdn:main Apr 12, 2022
@ddbeck ddbeck deleted the revert-12169-esm-packaging branch April 12, 2022 12:55
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Apr 12, 2022
Revert "Revert "Package data for NPM as ESM and CJS (mdn#12169)" (mdn#15774)"

This reverts commit 6f3a8b7.
@queengooborg
Copy link
Contributor

queengooborg commented Apr 12, 2022

I'm confused by the revert here, because didn't we all give the green light for the ESM work during the last OWD-MDN planning meeting? My question was answered in offline conversation, apologies for the hasty merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues or pull requests regarding the documentation of this project. scripts Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants