-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirroring script: Combine statements in array #16342
Merged
queengooborg
merged 11 commits into
mdn:main
from
queengooborg:scripts/mirror/combineStatements
May 21, 2022
+122
−4
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dcfcafb
Mirroring script: Combine statements in array
queengooborg cb4c0ef
Fix logic for arrays
queengooborg a3c0978
Merge branch 'main' into scripts/mirror/combineStatements
queengooborg 1983cb6
Fix formatting
queengooborg 69d2829
Merge branch 'main' into scripts/mirror/combineStatements
queengooborg a043356
Fix bad merge
queengooborg b2252fc
Fix variables
queengooborg 4bdaa5c
Apply suggestions from code review
queengooborg 6a2dee8
Fix ESLint errors
queengooborg ae412a1
Merge branch 'main' into scripts/mirror/combineStatements
queengooborg 16f84e2
Merge branch 'main' into scripts/mirror/combineStatements
queengooborg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this deduplicate the notes? And wasn't the old implementation broken, i.e. the block returned
undefined
for every note?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, for both!