Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resize event from GlobalEventHandlers #16723

Merged
merged 7 commits into from
Jul 7, 2022
Merged

Remove resize event from GlobalEventHandlers #16723

merged 7 commits into from
Jul 7, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the resize event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 18, 2022
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 18, 2022
@queengooborg queengooborg mentioned this pull request Jun 19, 2022
Closed
@foolip
Copy link
Contributor

foolip commented Jun 22, 2022

There are a few different "resize" events on the platform, and BCD already has PictureInPictureWindow, VisualViewport and Window. But a "resize" event for HTMLMediaElement is missing. That event is fired when the initial size of a video is learned, and if it later changes. Can you add a "resize_event" entry with the same data as the "loadeddata_event"?

@foolip
Copy link
Contributor

foolip commented Jun 29, 2022

I've sent #16827 to add the "resize" event on HTMLVideoElement.

@foolip
Copy link
Contributor

foolip commented Jun 29, 2022

I tried to trim this PR to just the removal from GlobalEventHandlers but made a mess of it in Window. Not sure if it makes sense, but there are no changes there now.

@foolip foolip changed the title Demix resize event from GlobalEventHandlers Remove resize event from GlobalEventHandlers Jun 29, 2022
foolip
foolip reviewed Jul 7, 2022
View reviewed changes
api/GlobalEventHandlers.json
"version_added": "12",
"version_removed": "79",
"partial_implementation": true,
"notes": "In EdgeHTML versions of Edge, this handler was only supported on the <a href='https://developer.mozilla.org/docs/Web/API/Window'><code>Window</code></a> API."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this was about missing onresize for <video> elements, and I've sent #16865 to fix this.

@queengooborg queengooborg mentioned this pull request Jul 7, 2022
Merged
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 7, 2022
@queengooborg queengooborg enabled auto-merge (squash) July 7, 2022 08:16
@queengooborg queengooborg merged commit 4da01aa into mdn:main Jul 7, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/resize branch July 7, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @foolip