Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix select event from GlobalEventHandlers #16731

Merged
merged 10 commits into from
Jul 9, 2022
Merged

Demix select event from GlobalEventHandlers #16731

merged 10 commits into from
Jul 9, 2022

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jun 19, 2022 •
edited
Loading

This PR demixes the select event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 19, 2022
@queengooborg queengooborg mentioned this pull request Jun 19, 2022
Closed
@queengooborg queengooborg changed the title Demix selection events from GlobalEventHandlers Demix select event from GlobalEventHandlers Jun 19, 2022
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 19, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

foolip
foolip reviewed Jul 5, 2022
View reviewed changes
foolip
foolip reviewed Jul 5, 2022
View reviewed changes
foolip
foolip requested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I think we should add "select_event" entries to HTMLInputElement and HTMLTextAreaElement. These are the interfaces that have selectionStart and related APIs that can end up firing this event.

Please remove the existing "select_event" entry on Element.

@queengooborg queengooborg mentioned this pull request Jul 9, 2022
Merged
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 9, 2022
@queengooborg queengooborg merged commit d697f12 into mdn:main Jul 9, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/select branch July 25, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @foolip