Web APIs: update Notification with MDN compat data #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmedley
suggested changes
Apr 11, 2018
There was a problem hiding this comment.
This interface has a bunch of items marked null that are actually true. You can find them here: https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/notifications/notification.idl
Elchi3
added
the
data:api
|
I have incorporated Chrome and Firefox compat data from the corresponding source code, so ready to merge from my side. |
jpmedley
approved these changes
Apr 23, 2018
Elchi3
approved these changes
Apr 26, 2018
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
May 11, 2022
Original source: mdn#1768 No evidence for the specific versions were given. The mere exposure of Notification in dedicated workers can be confirmed to be Chrome 41 with this test: https://mdn-bcd-collector.appspot.com/tests/api/Notification?exposure=Worker However, Notifications can't be created from dedicated workers in Chromium, it makes more sense to match support in service workers, which is one version later. That then matches notes and other data like api.NotificationEvent and api.ServiceWorkerRegistration.showNotification. Part of mdn#7844.
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
May 11, 2022
Original source: mdn#1768 No evidence for the specific versions was given. The mere exposure of Notification in dedicated workers can be confirmed to be Chrome 41 with this test: https://mdn-bcd-collector.appspot.com/tests/api/Notification?exposure=Worker However, Notifications can't be created from dedicated workers in Chromium, it makes more sense to match support in service workers, which is one version later. That then matches notes and other data like api.NotificationEvent and api.ServiceWorkerRegistration.showNotification. Part of mdn#7844.
queengooborg
pushed a commit
that referenced
this pull request
May 11, 2022
Original source: #1768 No evidence for the specific versions was given. The mere exposure of Notification in dedicated workers can be confirmed to be Chrome 41 with this test: https://mdn-bcd-collector.appspot.com/tests/api/Notification?exposure=Worker However, Notifications can't be created from dedicated workers in Chromium, it makes more sense to match support in service workers, which is one version later. That then matches notes and other data like api.NotificationEvent and api.ServiceWorkerRegistration.showNotification. Part of #7844.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification