-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update support data for Chrome Android (API's G through M) #18360
Conversation
These changes were generated procedurally by the mdn-bcd-collector project [1] using data collected from Chrome for Android [2]. [1] https://github.com/foolip/mdn-bcd-collector commit 06ea2714451c548934849011e4106b3175adfab5 [2] https://github.com/foolip/mdn-bcd-results commit f37e6db1da24143bf039ed8e269c9f234d2b4e90
@@ -47,7 +47,9 @@ | |||
"chrome": { | |||
"version_added": "4" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HTMLAllCollection
tests are broken, fixing them in foolip/mdn-bcd-collector#2641.
Can you drop these changes?
@@ -2792,7 +2792,9 @@ | |||
"chrome": { | |||
"version_added": "49" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But there's a note from setSinkId
that we should have here too:
"version_added": false | |
"version_added": false, | |
"notes": "Not available due to <a href='https://crbug.com/648286'>a limitation in Android</a>." |
@@ -41,7 +41,9 @@ | |||
"chrome": { | |||
"version_added": "52" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are broken, fixed in foolip/mdn-bcd-collector#2642.
@@ -7,7 +7,9 @@ | |||
"chrome": { | |||
"version_added": "94" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This interface has the wrong name in Chromium:
https://bugs.chromium.org/p/chromium/issues/detail?id=1404901
I've fixed the test in foolip/mdn-bcd-collector#2643 and expect that would lead to no change in the data here.
@@ -75,7 +75,9 @@ | |||
"chrome": { | |||
"version_added": "40" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot wrong with the data for InstallEvent
and I think it should just be deleted.
In the spec the "install" event is an ExtendableEvent
:
https://w3c.github.io/ServiceWorker/#service-worker-global-scope-install-event
InstallEvent
is still in Chromium source but has no extra members, so one can still treat it as an ExtendableEvent
.
@@ -82,7 +82,9 @@ | |||
"chrome": { | |||
"version_added": "102" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -294,7 +296,9 @@ | |||
"chrome": { | |||
"version_added": "102" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -8,7 +8,9 @@ | |||
"chrome": { | |||
"version_added": "94" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This turned out to be an interesting one.
https://mdn-bcd-collector.appspot.com/tests/api/MediaStreamTrackProcessor shows no support on desktop either, but note that the tests are for workers. The interface is exposed in only the window context in Chrome, but there's a ominous note in https://w3c.github.io/mediacapture-transform/#track-processor-interface:
There is WG consensus that the interface should be exposed on DedicatedWorker. There is no WG consensus on whether or not the interface should not be exposed on Window.
So what should this BCD represent? I think we should probably have a note that says it's only exposed in window, at the very least.
I've also commented at w3c/mediacapture-transform#66 (comment).
@@ -7,7 +7,9 @@ | |||
"chrome": { | |||
"version_added": "13" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here is LegacyNoInterfaceObject
:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/filesystem/metadata.idl;l=33;drc=f5eccec110f06a006f4ec2b249b3c4b92e7dac35
In other words, the generated test can't work. I'm removing them in foolip/mdn-bcd-collector#2650.
@@ -8,7 +8,9 @@ | |||
"chrome": { | |||
"version_added": "1" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is a bit tricky. I think Chrome Android does support navigator.mimeTypes
, which is a MimeTypeArray
, but it won't have any entries. So then what makes sense to say about MimeType
? I think they should have the same status, but the collector tests would need some fixing for this.
Filing an idea in foolip/mdn-bcd-collector#2651.
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
1 similar comment
This pull request has merge conflicts that must be resolved before it can be merged. |
Given how much iteration there has been on the collector project since this PR was opened (December 2022), I am going to close this. |
Summary
These changes were generated procedurally by the mdn-bcd-collector project [1] using data collected from Chrome for Android [2].
[1] https://github.com/foolip/mdn-bcd-collector
commit 06ea2714451c548934849011e4106b3175adfab5
[2] https://github.com/foolip/mdn-bcd-results
commit f37e6db1da24143bf039ed8e269c9f234d2b4e90
Test results and supporting details
Related issues
This changeset is based on the one originally submitted via #17908. It uses compatibility data which has been collected since that patch was created, and it includes only a subset of the changes generated by the mdn-bcd-collector.