Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path() to browser compat table of shape-outside property #19225

Merged
merged 2 commits into from
May 16, 2023

Conversation

dipikabh
Copy link
Contributor

@dipikabh dipikabh commented Mar 24, 2023

Fixes #19228

Summary

This is an extension of the fix in mdn/content#25588.

The path() entry is missing in the browser compat table for the shape-outside property.

Supporting details

The information for path() is copied from the browser compat on the basic-shape page.
Source:

"path": {
"__compat": {
"description": "<code>path()</code>",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/path",
"spec_url": "https://w3c.github.io/csswg-drafts/css-shapes/#funcdef-basic-shape-path",
"support": {
"chrome": {
"version_added": "46",
"partial_implementation": true,
"notes": "Only supported on the <code>offset-path</code> property."
},
"chrome_android": "mirror",
"edge": "mirror",
"firefox": [
{
"version_added": "97",
"partial_implementation": true,
"notes": "Only supported on the <code>d</code> SVG presentation attribute and the <code>clip-path</code> and <code>offset-path</code> CSS properties. Not supported on the <code>shape-outside</code> CSS property."
},
{
"version_added": "71",
"partial_implementation": true,
"notes": "Only supported on the <code>clip-path</code> and <code>offset-path</code> properties."
},
{
"version_added": "63",
"partial_implementation": true,
"notes": "Only supported on the <code>offset-path</code> property."
}
],
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
).

Related issues

mdn/content#9703

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Mar 24, 2023
@dipikabh dipikabh requested review from Elchi3 and queengooborg April 3, 2023 15:08
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dipikabh, I think just copying it over doesn't work.

"chrome": {
"version_added": "46",
"partial_implementation": true,
"notes": "Only supported on the <code>offset-path</code> property."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is confusing.

Only supported on the offset-path property.

This sentence makes sense if you are on the basic-shape page. But this BCD is for a specific property, shape-outside, and so I guess the path() support should be false?

@dipikabh
Copy link
Contributor Author

Hello @Elchi3, thanks a lot for taking the time to review this. Apologies it took me this long to get back to this.

This sentence makes sense if you are on the basic-shape page. But this BCD is for a specific property, shape-outside, and so I guess the path() support should be false?

You are correct in pointing this out. In fact, shape-outside does not support the path() function in Firefox, Chrome, and Safari. I've updated the PR.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dipikabh! 👍

@Elchi3 Elchi3 merged commit 9e71ec7 into mdn:main May 16, 2023
@dipikabh dipikabh deleted the shape-outside-path branch May 16, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css.properties.shape-outside - BCD for path() value missing
2 participants