Improve data about async versions of filesystemsyncaccesshandle methods #20621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
|
We shouldn't be creating "negative features" like what's been done here. Additionally, the feature was supported in Chrome 102, just as an asynchronous method, so this is conflicting with collector results. |
This was referenced Sep 18, 2023
queengooborg
added a commit
to queengooborg/browser-compat-data
that referenced
this pull request
Sep 18, 2023
This PR updates and corrects version values for all browsers for the `FileSystemSyncAccessHandle` API. This effectively reverts mdn#20621 first, and then fixes the data. (Chrome supported the synchronous version since 108 without a flag, and Safari since 16.4.)
queengooborg
added a commit
that referenced
this pull request
Sep 18, 2023
This PR updates and corrects version values for all browsers for the `FileSystemSyncAccessHandle` API. This effectively reverts #20621 first, and then fixes the data. (Chrome supported the synchronous version since 108 without a flag, and Safari since 16.4.)
chrisdavidmills
deleted the
ammend-filesystemsyncaccesshandle-async-data
branch
Elchi3
pushed a commit
to Elchi3/browser-compat-data
that referenced
this pull request
Nov 14, 2023
Elchi3
pushed a commit
to Elchi3/browser-compat-data
that referenced
this pull request
Nov 14, 2023
This PR updates and corrects version values for all browsers for the `FileSystemSyncAccessHandle` API. This effectively reverts mdn#20621 first, and then fixes the data. (Chrome supported the synchronous version since 108 without a flag, and Safari since 16.4.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As detailed in mdn/content#28647, the sync support data is misleading/wrong; the incorrect async versions of these methods are no longer supported in any modern browser. This PR improves the data as suggested.
Test results and supporting details
Related issues
Fixes mdn/content#28647