FF131 Secure attr must be set if SameSite=None #24275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:http
8 tasks
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
|
@Elchi3 @queengooborg Could I please get a review on this - I did it about a month ago and the release is today. |
caugner
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF131 enables preference by default such that if
SameSite=NonetheSecureattribute must be set in https://bugzilla.mozilla.org/show_bug.cgi?id=1909673Unfortunately this required a little more than just replacing the pref subfeature with a version.
The pref was named "secure_context_required", which is incorrect for HTTP headers (it's reasonable for APIs though). The requirement is actually about what headers must be set, so I have renamed this to
secure_required_if_noneand put a proper description. Could also have moved this below theNoneoption, but I think this level is better.It would be good if we also had an entry for the
Secureattribute, at the same level asHttpOnly. However I do not have support data for that.Related docs work can be tracked in mdn/content#35697