Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF131 PointerEvent.PointerEvent() - azimuthAngle, altitudeAngle options #24393

Merged

Conversation

hamishwillee
Copy link
Contributor

FF131 Added support for PointerEvent.altitudeAngle and azimuthAngle in https://bugzilla.mozilla.org/show_bug.cgi?id=1656377

We added the features for the properties themselves in #24332. This adds the same properties for the constructor argument options. Note I only added the new ones, not the ones that should have been there "forever".

FYI @Elchi3 Don't know if the collector can be updated to detect these being supported.

Related docs work can be tracked in mdn/content#35721

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 9, 2024
@@ -90,6 +90,72 @@
"standard_track": true,
"deprecated": false
}
},
"options_altitudeAngle_parameter": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just copies the property, indents two spaces, and names as an option.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hamish, I think so far we've only added constructor options on an as-needed-basis, but if you think we should have them here, let's do this.

The collector doesn't systematically add constructor options. I imagine there would be quite a lot of them.

@Elchi3 Elchi3 merged commit c209af6 into mdn:main Sep 9, 2024
5 checks passed
@hamishwillee hamishwillee deleted the ff131_pointerevent_constructor_angles branch September 9, 2024 23:20
@hamishwillee
Copy link
Contributor Author

Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants