Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-pr): grant permissions #24935

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 4, 2024

Summary

Grants the release-pr permissions, so that the workflow has access to secrets on Dependabot merges.

Test results and supporting details

Related issues

Otherwise the workflow has no access to secrets, when run on a Dependabot merge.
@github-actions github-actions bot added the infra Infrastructure issues (npm, GitHub Actions, releases) of this project label Nov 4, 2024
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, as this fixes a failing workflow.

@caugner caugner enabled auto-merge (squash) November 4, 2024 12:35
@caugner caugner merged commit 70d53bd into main Nov 4, 2024
7 checks passed
@caugner caugner deleted the fix-release-pr-permissions branch November 4, 2024 12:36
caugner added a commit that referenced this pull request Nov 18, 2024
caugner added a commit that referenced this pull request Nov 18, 2024
…ndabot/release commits (#25114)

* Revert "fix(release-pr): grant permissions (#24935)"

This reverts commit 70d53bd.

* fix(workflows/release-pr): ignore Dependabot merges

* fix(workflows/release-pr): do not run on Release commits

At this point the release is not yet created/tagged, so
the created PR would have the same version and changes,
until this is updated by the next commit.

* fix(workflows/release-pr): overwrite GITHUB_TOKEN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant