Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): migrate from ts-node to tsx #25603

Merged
merged 7 commits into from
Jan 9, 2025
Merged

chore(deps): migrate from ts-node to tsx #25603

merged 7 commits into from
Jan 9, 2025
+546 −1,561

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 8, 2025 •
edited
Loading

Summary

Migrates from ts-node to tsx.

Test results and supporting details

ts-node is no longer maintained (last update 2 years ago), and doesn't work on Node.js 22 with SWC and Import Attributes.

Since tsx ignores the experimental warning related to "Import assertions", we no longer need the corresponding option.

Related issues

Fixes #25596.

@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project dependencies Pull requests that update a dependency package or file. scripts Issues or pull requests regarding the scripts in scripts/. size:l [PR only] 101-1000 LoC changed labels Jan 8, 2025
@caugner caugner force-pushed the migrate-from-ts-node-to-tsx branch from 32610ac to eb5a4fe Compare January 8, 2025 10:30
@caugner caugner mentioned this pull request Jan 8, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. size:xl [PR only] >1000 LoC changed and removed size:l [PR only] 101-1000 LoC changed labels Jan 8, 2025
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jan 8, 2025
@caugner caugner requested review from queengooborg and Elchi3 January 8, 2025 16:58
@caugner caugner requested a review from queengooborg January 9, 2025 08:27
queengooborg
queengooborg approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be sad to move away from SWC because it was a wonderful transpiler, but ts-node not being maintained is much more of a problem.

@Elchi3 Elchi3 merged commit f986486 into main Jan 9, 2025
12 checks passed
@Elchi3 Elchi3 deleted the migrate-from-ts-node-to-tsx branch January 9, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency package or file. infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:xl [PR only] >1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project compatibility with Node 22 LTS
3 participants
@caugner @Elchi3 @queengooborg