Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts/diff-features): fetch missing ref #25679

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix(scripts/diff-features): fetch missing ref #25679

merged 1 commit into from
Jan 17, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 16, 2025

Summary

Makes the diff-features script more resilient to missing refs.

Test results and supporting details

In our case, the GitHub API returns the wrong merge commit, which is not in the main branch.

As a workaround, let's fall back to fetching the missing commit.

Related issues

Fixes #25678.

@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:s [PR only] 7-24 LoC changed labels Jan 16, 2025
Elchi3
Elchi3 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Claas, let's try this!

@Elchi3 Elchi3 merged commit 3fd5f96 into main Jan 17, 2025
10 checks passed
@Elchi3 Elchi3 deleted the 25678-fetch-missing-ref branch January 17, 2025 11:18
caugner added a commit that referenced this pull request Jan 17, 2025
@caugner
Revert "fix(scripts/diff-features): fetch missing ref (#25679)"
4d55553 
This reverts commit 3fd5f96.
caugner added a commit that referenced this pull request Jan 17, 2025
@caugner
Revert "fix(scripts/diff-features): fetch missing ref (#25679)"
f7a8769 
This reverts commit 3fd5f96.
Elchi3 pushed a commit that referenced this pull request Jan 17, 2025
@caugner
fix(script/diff-features): replace wrong merge commit ref (#25692)
f265d18 
* Revert "fix(scripts/diff-features): fetch missing ref (#25679)"

This reverts commit 3fd5f96.

* fix(script/diff-features): replace wrong merge commit ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@queengooborg queengooborg Awaiting requested review from queengooborg

Assignees
No one assigned
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:s [PR only] 7-24 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release workflow fails
2 participants
@caugner @Elchi3