Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Chrome support for RTCPeerConnection parameters #25697

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Fix Chrome support for RTCPeerConnection parameters #25697

merged 2 commits into from
Jan 20, 2025
+23 −33

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 17, 2025

Summary

Fixes Chrome support data for the following RTCPeerConnection parameters:

  • iceCandidatePoolSize
  • iceServers
  • iceTransportPolicy (aka iceTransports)

Test results and supporting details

See #16595 (comment) for the evidence.

Related issues

Fixes #16595.

@caugner caugner requested a review from Elchi3 January 17, 2025 16:28
@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Jan 17, 2025
Elchi3
Elchi3 requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the build failure, some sub features are earlier than the parent now and that doesn't work.

@caugner caugner requested a review from Elchi3 January 18, 2025 00:05
@Elchi3 Elchi3 merged commit 2db27cd into main Jan 20, 2025
11 checks passed
@Elchi3 Elchi3 deleted the 16595-fix-rtc-configuration-data branch January 20, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTCPeerConnection constructor parameters are probably wrong
2 participants
@caugner @Elchi3