Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import(…, { with: { type: "json" } }) is standard track #25995

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Feb 21, 2025

Summary

The options argument for import() is just as standardized as the rest of import attributes.

Test results and supporting details

https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-import-call-runtime-semantics-evaluation

Related issues

@github-actions github-actions bot added data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:xs [PR only] 0-6 LoC changed labels Feb 21, 2025
@ddbeck ddbeck changed the title import(…, { with: "json" }) is standard track import(…, { with: { type: "json" } }) is standard track Feb 21, 2025
@@ -954,7 +954,7 @@
},
"status": {
"experimental": false,
"standard_track": false,
"standard_track": true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set this as well, since it appears to be reflecting the same underlying fact.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with 8ba99d2.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's no reason not to do it for both features. I've added it with 52ed946.

@github-actions github-actions bot added size:s [PR only] 7-24 LoC changed and removed size:xs [PR only] 0-6 LoC changed labels Feb 22, 2025
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@caugner caugner merged commit 1790762 into mdn:main Feb 24, 2025
7 checks passed
@ddbeck ddbeck deleted the dynamic-import-assertion-standard branch February 24, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants