Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(scripts/tag-web-features): print changes as patch code block #26052

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 25, 2025

Summary

Improves the tag-web-features script output by printing a patch code block, instead of structured prose.

Test results and supporting details

The PRs (like this one) are cumbersome to review manually.

Compare the OP with this comment (created via this branch).

Related issues

@caugner caugner requested a review from queengooborg February 25, 2025 12:53
@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:m [PR only] 25-100 LoC changed labels Feb 25, 2025
@caugner caugner requested a review from Elchi3 February 28, 2025 10:22
@caugner
Copy link
Contributor Author

caugner commented Feb 28, 2025

@queengooborg @Elchi3 It would be nice to land this change, as PRs like #26052 are hard to review, and this makes it significantly easier to get an overview of the changes (see example in PR description).

@queengooborg
Copy link
Contributor

queengooborg commented Feb 28, 2025

Please feel free to consider me as a rubber stamp approval!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!! Nice 🎉

@Elchi3 Elchi3 merged commit a975075 into main Feb 28, 2025
11 checks passed
@Elchi3 Elchi3 deleted the improve-tag-web-features-output branch February 28, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants