[Chrome] Update MIDIAccess. #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
data:api
ddbeck
requested changes
Apr 2, 2019
api/MIDIAccess.json
Outdated
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/MIDIAccess/sysexEnabled", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "43" |
There was a problem hiding this comment.
Have I misunderstood something in your PR description or should this and all the versions below this one be 45?
|
PTAL |
ddbeck
approved these changes
Apr 2, 2019
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
May 9, 2022
Confirmed by testing in Chrome 43: https://mdn-bcd-collector.appspot.com/tests/api/MIDIAccess Chrome 45 was set in mdn#3716 based on this: https://storage.googleapis.com/chromium-find-releases-static/545.html#5455496fc3b82a0dc6645f78474f9ab5950a70bb But that's wrong. Part of mdn#7844.
queengooborg
pushed a commit
that referenced
this pull request
May 9, 2022
Confirmed by testing in Chrome 43: https://mdn-bcd-collector.appspot.com/tests/api/MIDIAccess Chrome 45 was set in #3716 based on this: https://storage.googleapis.com/chromium-find-releases-static/545.html#5455496fc3b82a0dc6645f78474f9ab5950a70bb But that's wrong. Part of #7844.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Everything else is Chrome 43. (I know I tell people not to trust Chrome Status, but I literally sit next to the MIDI spec author. He assures me this is correct.)