Misc. event refactoring #3764
Merged
Misc. event refactoring #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `pagehide` * `pageshow` * `rejectionhandled` * `unhandledrejection` Sources for `pageshow` and `pagehide`: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/1.5/Using_Firefox_1.5_caching. All other version information copied from the corresponding event handler properties. * `push` * `pushsubscriptionchange` Source: All version information taken from the corresponding event handler properties. * `paymentmethodchange` * `merchantvalidation` * `shippingaddresschange` * `shippingoptionchange` Source: All version information taken from the corresponding event handler properties. * `mute` * `unmute` Source: All version information taken from the corresponding event handler properties. * PromiseRejectionEvent (cleaned up notes that refer to changed events)
Elchi3
added
the
data:api
|
Assigned to Chris for review as planned during sprint planning meetings. |
chrisdavidmills
requested changes
Apr 9, 2019
There was a problem hiding this comment.
Hey @a2sheppy !
I've reviewed this, and it's looking mostly good. I had a few queries:
- I couldn't find
merchantvalidation/onmerchantvalidationinPaymentRequest. Add these? pageshow/pagehidelooks like it is only supported in Fx, from your data. Did you test it in other browsers? Is it therefore experimental, in which caseexperimentalshould be set totruefor those?- there's no entry for the
onrejectionhandledhandler. Add one?
I'm assuming you've written pages for these too — do you want me to review them as well?
|
As to #2, |
chrisdavidmills
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pagehidepageshowrejectionhandledunhandledrejectionSources for
pageshowandpagehide: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/1.5/Using_Firefox_1.5_caching.All other version information copied from the corresponding event handler properties.
pushpushsubscriptionchangeSource: All version information taken from the corresponding event handler properties.
paymentmethodchangemerchantvalidationshippingaddresschangeshippingoptionchangeSource: All version information taken from the corresponding event handler properties.
muteunmuteSource: All version information taken from the corresponding event handler properties.
A checklist to help your pull request get merged faster: