-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix CODEOWNERS #3933
chore: Fix CODEOWNERS #3933
Conversation
17302ec
to
1cdc630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you beat me to this one -- I was assuming that !*.json
would do the trick, but I've noticed that it wasn't actually working. (Never actually submitted a webextensions change either, so I didn't have a test for it.)
In the original PR (#3800), we discussed that non-JSON files would add @Elchi3, and only them. I think that we should keep it like that, at least for the time being. Furthermore, I would advise adding an entries for *.md
and *.ts
, and eliminating the *.json
part of /schemas/*.json
, as it would cover most all of the non-data updates we're looking for.
Thanks for tackling this, by the way!
Thanks for working on this! I also believe that the mechanics of flagging all owners all the time is counter productive. I don't need to be the one reviewing all these PRs in the end, but I want to have a look, triage the issue, and then I can add other owners. Also, some owners almost never review PRs, but are working more on the overall strategy of the project. Daniel and I are probably the ones who most likely have a look at owner PRs right now. The others less so. We will need to try and adjust. This workflow needs to work for the people in question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add only me for now for schema, linter, infra auto review assignments. The other owners aren't always tasked with the daily PR review business. I will triage and assign other owners as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ExE-Boss 👍
Let's merge this and adjust if needed.
This fixes the
CODEOWNERS
file to correctly request reviews when a schema, linter or infra change is made.With this, it will be possible to enable required code owner reviews: https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests
review?(@Elchi3)