Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint MDN URLs for localization code #417

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Sep 27, 2017

This adds a linter check for MDN URLs which have a language code (e.g., /en-US/). I started this before the schema change in #413, so there's a bit of overlap, but I think it might still be useful, since it checks notes in addition to the value of "mdn_url".

@teoli2003 teoli2003 added enhancement Nice to have features. linter Issues or pull requests regarding the tests / linter of the JSON files. labels Sep 27, 2017
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Nice to have features. linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants