Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove html.elements.track.cuechange_event #5244

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Remove html.elements.track.cuechange_event #5244

merged 1 commit into from
Dec 3, 2019

Conversation

bershanskiy
Copy link
Contributor

Summary

This data is stored as api.HTMLTrackElement.cuechange_event.

This was found while working on #5201.

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@bershanskiy
Remove html.elements.track.cuechange_event
d0c83ea 
This data is stored as `api.HTMLTrackElement.cuechange_event`
@ghost ghost added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Dec 1, 2019
queengooborg
queengooborg approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Since events are an API thing, we should keep the data in the API folder. Let's get this merged!

@queengooborg queengooborg merged commit 5d817a5 into mdn:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bershanskiy @queengooborg