Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css.types.angle-percentage: delete child elements #5258

Merged
merged 2 commits into from
Dec 12, 2019
Merged

css.types.angle-percentage: delete child elements #5258

merged 2 commits into from
Dec 12, 2019

Conversation

bershanskiy
Copy link
Contributor

Summary

Fix mdn_url for css.types.angle-percentage

Related issues

This is one of the issues found by #5201

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@ghost ghost added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Dec 4, 2019
@Elchi3
Copy link
Member

Elchi3 commented Dec 4, 2019

Hm well, there is no documentation under https://developer.mozilla.org/en-US/docs/Web/CSS/angle-percentage#deg but there is under https://developer.mozilla.org/en-US/docs/Web/CSS/angle#deg.
So, the URLs are correct, I guess?

@bershanskiy
Copy link
Contributor Author

Hm well, there is no documentation under https://developer.mozilla.org/en-US/docs/Web/CSS/angle-percentage#deg but there is under https://developer.mozilla.org/en-US/docs/Web/CSS/angle#deg.

That can be easily fixed, if desired (I could update English locale and add stubs to all other locales). As is, the docs URLs are a bit misleading and kinda defeat having <angle-percentage> page at all.

@Elchi3
Copy link
Member

Elchi3 commented Dec 4, 2019

Thank you so much for volunteering to fix this!
I don't really know why things are set up the way they are. Maybe @rachelandrew has thoughts on the matter?

@rachelandrew
Copy link
Collaborator

I think it just hasn't been added there yet so if you want to add it that would be great!

@bershanskiy
Copy link
Contributor Author

@Elchi3 @rachelandrew

Actually, now that I had more time to think about it I don't understand the need for <angle> types under <angle-percentage> data type. Specifically, since <angle-percentage> is equivalent to [ <angle> | <percentage> ], then all degree units/types children of css.types.angle-percentage have to be exactly the same as under css.types.angle; the percentage type/unit is just that -- a percentage.

So it would make more sense to me if we just deleted the redundant data:

  • css.types.angle-percentage.deg (already stored as css.types.angle.deg),
  • css.types.angle-percentage.grad (already stored as css.types.angle.grad),
  • css.types.angle-percentage.rad (already stored as css.types.angle.rad), and
  • css.types.angle-percentage.turn (already stored as css.types.angle.turn).
    That would shrink angle-percentage.json to only contain css.types.angle-percentage.__compat.

Is there something I'm missing like angle-percentage interaction with other stuff?

@bershanskiy bershanskiy changed the title Fix mdn_url for css.types.angle-percentage css.types.angle-percentage: delete child elements Dec 6, 2019
@Elchi3
Copy link
Member

Elchi3 commented Dec 10, 2019

This seems like the right call to me, but @rachelandrew might know more here.

@rachelandrew
Copy link
Collaborator

LGTM

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bershanskiy! I think we're good to go on this since we have two approvals already. 😉

@queengooborg queengooborg merged commit bc47a3f into mdn:master Dec 12, 2019
@bershanskiy bershanskiy deleted the mdn_url-css.types.angle-percentage branch December 12, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants