-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css.types.angle-percentage: delete child elements #5258
css.types.angle-percentage: delete child elements #5258
Conversation
Hm well, there is no documentation under https://developer.mozilla.org/en-US/docs/Web/CSS/angle-percentage#deg but there is under https://developer.mozilla.org/en-US/docs/Web/CSS/angle#deg. |
That can be easily fixed, if desired (I could update English locale and add stubs to all other locales). As is, the docs URLs are a bit misleading and kinda defeat having |
Thank you so much for volunteering to fix this! |
I think it just hasn't been added there yet so if you want to add it that would be great! |
Actually, now that I had more time to think about it I don't understand the need for So it would make more sense to me if we just deleted the redundant data:
Is there something I'm missing like |
This seems like the right call to me, but @rachelandrew might know more here. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bershanskiy! I think we're good to go on this since we have two approvals already. 😉
Summary
Fix mdn_url for css.types.angle-percentage
Related issues
This is one of the issues found by #5201
A checklist to help your pull request get merged faster: