Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove broken MDN URLs: webextensions.api.events #5279

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Remove broken MDN URLs: webextensions.api.events #5279

merged 1 commit into from
Dec 6, 2019

Conversation

bershanskiy
Copy link
Contributor

Summary

These URLs do not exist and they do not follow the MDN URL convention.

These URLs fail during test with linter from #5201, so they block #5273 or require an exception.

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • [ x Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@bershanskiy
Remove broken MDN URLs: webextensions.api.events
90fae0d 
These URLs do not exist and they do not follow the MDN URL convention.
@bershanskiy bershanskiy requested a review from rebloor as a code owner December 6, 2019 00:20
@ghost ghost added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Dec 6, 2019
@rebloor rebloor merged commit 0f44c68 into mdn:master Dec 6, 2019
@bershanskiy bershanskiy deleted the linter.webextensions.api.events branch December 6, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebloor rebloor Awaiting requested review from rebloor

Assignees
No one assigned
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bershanskiy @rebloor