Complete nodejs data for Symbol #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
data:js
I think this makes sense, although I don't know how this behaves with other nodes builtin objects. |
Elchi3
approved these changes
Jun 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6249. This fills in the
truevalues for Node inSymbol.Data source: https://node.green/#ES2015-built-ins-Symbol and local testing
I also changed the value on
Symbol.toStringTag.dom-objectsfromtruetofalse. Node.js doesn't support any DOM prototype objects, so it can't supportSymbol.toStringTagon them. If that change is erroneous, I'm happy to revert it.