Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete nodejs data for grammar #6332

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Complete nodejs data for grammar #6332

merged 1 commit into from
Jun 25, 2020

Conversation

gilmoreorless
Copy link
Contributor

Part of #6249. This fills in true values for Node in grammar, and clarifies one existing versioned entry by adding --harmony flag info.

Most of the grammar was supported in the first version of Node, and for the rest the data comes from https://node.green and local testing.

@ghost ghost added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jun 25, 2020
Elchi3
Elchi3 approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing surprises me here, well done! 👍

@Elchi3 Elchi3 merged commit 8577a64 into mdn:master Jun 25, 2020
@Elchi3 Elchi3 mentioned this pull request Jul 6, 2020
Closed
@gilmoreorless gilmoreorless deleted the nodejs-grammar branch August 31, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilmoreorless @Elchi3