Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BudgetService/BudgetState to reflect that they're gone #6535

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Aug 19, 2020

Only the reserve() method was shipped, and later removed:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/yBtmc-4xl_o/GE0vneAVDQAJ
https://groups.google.com/a/chromium.org/d/msg/blink-dev/18r3whCBv0I/b8qrtFTsDAAJ

https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8362 was
tested on Chrome and Opera on Windows to verify the ranges. Android
WebView was never supported per the blink-dev intent, and the other data
was mirrored.

Only the reserve() method was shipped, and later removed:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/yBtmc-4xl_o/GE0vneAVDQAJ
https://groups.google.com/a/chromium.org/d/msg/blink-dev/18r3whCBv0I/b8qrtFTsDAAJ

https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8362 was
tested on Chrome and Opera on Windows to verify the ranges. Android
WebView was never supported per the blink-dev intent, and the other data
was mirrored.
@ghost ghost added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 19, 2020
@foolip
Copy link
Contributor Author

foolip commented Aug 19, 2020

@vinyldarkscratch can you review this?

@ddbeck
Copy link
Collaborator

ddbeck commented Aug 19, 2020

Opened #6536 to eventually remove this outright, provided this PR checks out.

@foolip
Copy link
Contributor Author

foolip commented Aug 19, 2020

I agree with removing for sure. Given that there are MDN pages, what's the process for doing that? First remove the pages on MDN, then the compat data? Can anyone remove pages, or can one request it somehow?

@ddbeck
Copy link
Collaborator

ddbeck commented Aug 19, 2020

Pages on MDN ought to be archived. I haven't actually done it myself though. I believe it requires a special permission to do, but Chris Mills can grant it if the person doing the work doesn't have it already. (Still a couple months off though, since the guideline calls for waiting 2 years from when all browsers stop shipping the feature.)

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all good to me -- thanks! 👍

@queengooborg queengooborg merged commit b0fe67d into mdn:master Aug 20, 2020
@foolip foolip deleted the budget-service-state branch August 20, 2020 07:28
@foolip
Copy link
Contributor Author

foolip commented Aug 20, 2020

I see, thanks @ddbeck! I guess BudgetState could be archived right away since it never shipped, but it doesn't matter much if it stays around until BudgetService is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants