Mirroring script: Edge mirrors from both IE AND Chrome at the same time

docs/contributing.md

@@ -74,18 +74,18 @@ If the feature you're interested in is a JavaScript API, you can cross-reference
 
 Many browsers within BCD can be derived from other browsers given they share the same engine, for example Opera derives from Chrome, and Firefox Android derives from Firefox. To help cut down time working on copying values between browsers, a mirroring script is provided. You can run `npm run mirror <browser> <feature_or_file> [--source=""] [--modify=""]` to automatically copy values.
 
-The <browser> argument is the destination browser that values will be copied to. The script automatically determines what browser to copy from based upon the destination (see table below), but manual specification is possible through the `--source=""` argument.
-
-| Destination      | Default Source    |
-| ---------------- | ----------------- |
-| Chrome Android   | Chrome            |
-| Edge             | Internet Explorer |
-| Firefox Android  | Firefox           |
-| Opera            | Chrome            |
-| Opera Android    | Chrome Android    |
-| Safari iOS       | Safari            |
-| Samsung Internet | Chrome Android    |
-| WebView          | Chrome Android    |
+The <browser> argument is the destination browser that values will be copied to. The script automatically determines what browser to copy from based upon the destination (see table below), but manual specification is possible through the `--source=""` argument. (Mirroring data for Edge ignores this argument.)
+
+| Destination      | Default Source             |
+| ---------------- | -------------------------- |
+| Chrome Android   | Chrome                     |
+| Edge             | Internet Explorer + Chrome |
+| Firefox Android  | Firefox                    |
+| Opera            | Chrome                     |
+| Opera Android    | Chrome Android             |
+| Safari iOS       | Safari                     |
+| Samsung Internet | Chrome Android             |
+| WebView          | Chrome Android             |
 
 The <feature_or_filename> argument is either the identifier of the feature to update (i.e. `css.at-rules.namespace`), a filename (`javascript/operators/arithmetic.json`), or an entire folder (`api`).
 

scripts/mirror.js

@@ -219,71 +219,61 @@ const bumpChromeAndroid = (originalData, sourceData, source) => {
 };
 
 /**
- * @param {SupportStatement} originalData
- * @param {SupportStatement} sourceData
- * @param {string} source
+ * @param {SupportStatement} comp
  * @returns {SupportStatement}
  */
-const bumpEdge = (originalData, sourceData, source) => {
-  let newData = {};
-
-  if (source == 'ie') {
-    if (sourceData.version_removed && sourceData.version_removed !== null) {
-      newData.version_added = false;
-    } else if (sourceData.version_added !== null) {
-      newData.version_added = sourceData.version_added ? '12' : null;
-    }
+const bumpEdge = comp => {
+  let newData = comp['edge'];
+  let originalData = comp['edge'];
+  let ieData = comp['ie'];
+  let chromeData = comp['chrome'];
 
-    if (sourceData.notes) {
-      newData.notes = updateNotes(
-        sourceData.notes,
-        /Internet Explorer/g,
-        'Edge',
-      );
-    }
-  } else if (source == 'chrome') {
-    newData = originalData == undefined ? sourceData : originalData;
+  if (ieData.version_removed && ieData.version_removed !== null) {
+    newData.version_added = false;
+  } else if (ieData.version_added !== null) {
+    newData.version_added = ieData.version_added ? '12' : null;
+  }
 
-    let chromeFalse =
-      sourceData.version_added === false ||
-      sourceData.version_removed !== undefined;
-    let chromeNull = sourceData.version_added === null;
+  let chromeFalse =
+    chromeData.version_added === false ||
+    chromeData.version_removed !== undefined;
+  let chromeNull = chromeData.version_added === null;
 
-    if (originalData === undefined) {
-      newData.version_added = chromeFalse ? false : chromeNull ? null : '≤79';
-    } else {
-      if (!chromeFalse && !chromeNull) {
-        if (originalData.version_added == true) {
-          newData.version_added = '≤18';
-        } else {
-          if (
-            sourceData.version_added == true ||
-            Number(sourceData.version_added) <= 79
-          ) {
-            if (originalData.version_added == false) {
-              newData.version_added = '79';
-            } else if (originalData.version_added == null) {
-              newData.version_added = '≤79';
-            }
-          } else {
-            newData.version_added == sourceData.version_added;
+  if (originalData === undefined) {
+    newData.version_added = chromeFalse ? false : chromeNull ? null : '≤79';
+  } else {
+    if (!chromeFalse && !chromeNull) {
+      if (originalData.version_added == true) {
+        newData.version_added = '≤18';
+      } else {
+        if (
+          chromeData.version_added == true ||
+          Number(chromeData.version_added) <= 79
+        ) {
+          if (originalData.version_added == false) {
+            newData.version_added = '79';
+          } else if (originalData.version_added == null) {
+            newData.version_added = '≤79';
           }
+        } else {
+          newData.version_added == chromeData.version_added;
         }
-      } else if (chromeFalse) {
-        if (originalData.version_added && !originalData.version_removed) {
-          newData.version_removed = '79';
-        }
+      }
+    } else if (chromeFalse) {
+      if (originalData.version_added && !originalData.version_removed) {
+        newData.version_removed = '79';
       }
     }
+  }
 
-    let newNotes = combineNotes(
-      updateNotes(sourceData.notes, /Chrome/g, 'Edge'),
-      originalData.notes,
-    );
+  let newNotes = combineNotes(
+    updateNotes(ieData.notes, /Internet Explorer/g, 'Edge'),
+    updateNotes(chromeData.notes, /Chrome/g, 'Edge'),
+    originalData.notes,
+  );
 
-    if (newNotes) {
-      newData.notes = newNotes;
-    }
+  if (newNotes) {
+    newData.notes = newNotes;
   }
 
   return newData;
@@ -512,10 +502,7 @@ const bumpVersion = (data, destination, source, originalData) => {
   let newData = null;
   if (data == null) {
     return null;
-  } else if (
-    Array.isArray(data) &&
-    !(destination == 'edge' && source == 'chrome')
-  ) {
+  } else if (Array.isArray(data)) {
     newData = [];
     for (let i = 0; i < data.length; i++) {
       newData[i] = bumpVersion(data[i], destination, source, originalData);
@@ -527,9 +514,6 @@ const bumpVersion = (data, destination, source, originalData) => {
       case 'chrome_android':
         bumpFunction = bumpChromeAndroid;
         break;
-      case 'edge':
-        bumpFunction = bumpEdge;
-        break;
       case 'firefox_android':
         bumpFunction = bumpFirefoxAndroid;
         break;
@@ -594,7 +578,12 @@ const doSetFeature = (data, newData, rootPath, browser, source, modify) => {
   }
 
   if (doBump) {
-    let newValue = bumpVersion(comp[source], browser, source, comp[browser]);
+    let newValue = null;
+    if (browser == 'edge') {
+      newValue = bumpEdge(comp);
+    } else {
+      newValue = bumpVersion(comp[source], browser, source, comp[browser]);
+    }
     if (newValue !== null) {
       newData[rootPath].__compat.support[browser] = newValue;
     }