Update Firefox versions for MediaError API #7963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates and corrects the real values for Firefox and Firefox Android for the `MediaError` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v1.1.6). Results are manually confirmed for accuracy. Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/MediaError
github-actions
bot
added
the
data:api
foolip
reviewed
Dec 17, 2020
| @@ -14,10 +14,10 @@ | |||
| "version_added": "12" | |||
| }, | |||
| "firefox": { | |||
| "version_added": "3.5" | |||
| "version_added": "4" | |||
There was a problem hiding this comment.
The original "3.5" matches the data for api.HTMLMediaElement.error which is an instance of MediaError. This is most likely an interface object not exposed. Can you check this manually?
There was a problem hiding this comment.
I've tested http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8806 in Firefox 3.6 on BrowserStack and video.error is there. To make sure it wasn't just always null I checked when it was added and as part of that came across https://bugzilla.mozilla.org/show_bug.cgi?id=589561#c4. MediaError was originally HTMLMediaError and TimeRanges was HTMLTimeRanges.
I've sent #8734 to fix this.
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Jan 13, 2021
MediaError is the type of object used for video.error, which was shipped in Firefox 3.5. When TimeRanges was being implemented for Firefox 4, it was discovered that MediaError was incorrectly called HTMLMediaError, and manual testing in Firefox 3.6 confirms that interface object was exposed. It was fixed here: https://bugzilla.mozilla.org/show_bug.cgi?id=589561#c4 https://hg.mozilla.org/mozilla-central/rev/37f61e9d618a The point of this is to avoid the situation in mdn#7963, where looking for MediaError makes it seem like it was shipped in Firefox 4.
|
Closing in favor of #8734. |
sideshowbarker
pushed a commit
that referenced
this pull request
Jan 21, 2021
MediaError is the type of object used for video.error, which was shipped in Firefox 3.5. When TimeRanges was being implemented for Firefox 4, it was discovered that MediaError was incorrectly called HTMLMediaError, and manual testing in Firefox 3.6 confirms that interface object was exposed. It was fixed here: https://bugzilla.mozilla.org/show_bug.cgi?id=589561#c4 https://hg.mozilla.org/mozilla-central/rev/37f61e9d618a The point of this is to avoid the situation in #7963, where looking for MediaError makes it seem like it was shipped in Firefox 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and corrects the real values for Firefox and Firefox Android for the
MediaErrorAPI, based upon results from the mdn-bcd-collector project (v1.1.6). Results are manually confirmed for accuracy.Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/MediaError