Add WebView versions for HTMLMediaElement API #8334
Conversation
This PR adds real values for WebView Android for the `HTMLMediaElement` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v1.1.8). The collector obtains results based upon the latest WebView version (to determine if it is supported), then version numbers are copied from Chrome Android. Results are manually confirmed for accuracy. Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/HTMLMediaElement
github-actions
bot
added
the
data:api
api/HTMLMediaElement.json
Outdated
| @@ -357,7 +357,7 @@ | |||
| "version_added": "4.0" | |||
| }, | |||
| "webview_android": { | |||
| "version_added": "43" | |||
| "version_added": true | |||
There was a problem hiding this comment.
Why this change? A lot of the "43" in this file are wrong and would be fixed by testing the instance, maybe fix all of those first to ensure that no known-wrong data is being mirrored or overwritten in this PR? We should be able to fill in a real value here after the 43s and true values elsewhere are fixed.
There was a problem hiding this comment.
I actually don't know why I did this. I think I might've been thinking "I'll set it to true and fix these later", but we've got an issue open to track these down. Reverting these changes so that this PR is only increasing the amount of real values, not decreasing.
There was a problem hiding this comment.
Yep, let's get back to these in #7843.
| @@ -1003,7 +1003,7 @@ | |||
| "version_added": "5.0" | |||
| }, | |||
| "webview_android": { | |||
| "version_added": "49" | |||
| "version_added": false | |||
There was a problem hiding this comment.
Yep, confirmed by crbug.com/521319. I'll send a PR to link that issue after merging this.
| @@ -3648,7 +3651,7 @@ | |||
| "version_added": "5.0" | |||
| }, | |||
| "webview_android": { | |||
| "version_added": "49" | |||
| "version_added": false | |||
There was a problem hiding this comment.
Confirmed by crbug.com/589500.
This PR adds real values for WebView Android for the
HTMLMediaElementAPI, based upon results from the mdn-bcd-collector project (v1.1.8). The collector obtains results based upon the latest WebView version (to determine if it is supported), then version numbers are copied from Chrome Android. Results are manually confirmed for accuracy.Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/HTMLMediaElement