-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remix ParentNode #9064
Remix ParentNode #9064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can check this against the collector too, but don't block on that if you want to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied suggestions for everything the collector produced diffs for and then some. Hope it's clear what's from the collector and what's a safe guess, I've commented at least once for each but not attributed every single change to a source.
Since I've done this manually in the review UI, errors are still possible, please check for reasonableness.
Co-authored-by: Philip Jägenstedt <[email protected]>
Thanks, very useful to have this all in now! Firefox Android 78 doesn't exist, so it is bumped to 79. Otherwise it all made sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh, I discovered a lot more on a second look.
Co-authored-by: Philip Jägenstedt <[email protected]>
Thanks for the detailed second look! |
(Oh wow, what a mess.)
This PR takes apart the compat table at https://developer.mozilla.org/en-US/docs/Web/API/ParentNode#browser_compatibility and restructures things according to the new mixin data guideline.
Fun fact: In the past some folks suggested that documenting mixins instead of real APIs will lead to a lot of pages and that's why mixin pages are preferable. Well, all the pages happened anyway already!? All of the following pages exist in addition to the mixin page and so we had multiple data points (which this PR removes). Sigh.
https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/Element/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelectorAll
https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment/querySelectorAll
https://developer.mozilla.org/en-US/docs/Web/API/Element/querySelectorAll