-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat data for Headers (Fetch API) #929
Conversation
api/Headers.json
Outdated
}, | ||
"chrome_android": { | ||
"version_added": "40" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should all be 42.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
"version_added": "42" | ||
}, | ||
"chrome_android": { | ||
"version_added": "44" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you get the information about lexicographical sorting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developer.mozilla.org/en-US/docs/Web/API/Headers Here but I made an error - they should be null according to the old compat table.
"name": "" | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoever added this to the old compat table didn't get everything. These version added numbers apply to Android and Webview as well as desktop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
] | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This data applies to Opera Android as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
] | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These numbers also apply to Android and Webview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
] | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy to Opera Android.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
] | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy to Android and Webview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
] | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy to Opera Android.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
] | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy to Android and Webview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
] | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy to Opera Android.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
}, | ||
"firefox": [ | ||
{ | ||
"version_added": "52", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the entry with 52 and the note. This belongs to the get()
entry and not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
"flags": [ | ||
{ | ||
"type": "preference", | ||
"name": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dom.fetch.enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
"deprecated": false | ||
} | ||
}, | ||
"advanced_header_methods": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the whole "advanced_header_methods entry. It is redundant with the entries
, keys
, values
data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
} | ||
} | ||
}, | ||
"getall_removed": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the whole entry for "getall_removed". This is redundant with the info in getAll
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Headers", | ||
"support": { | ||
"webview_android": { | ||
"version_added": "42" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the complete thing for the Chrome family.
"webview_android": [
{
"version_added": "42"
},
{
"version_added": "41",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
],
"chrome": [
{
"version_added": "42"
},
{
"version_added": "41",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
],
"chrome_android": [
{
"version_added": "42"
},
{
"version_added": "41",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
"flags": [ | ||
{ | ||
"type": "preference", | ||
"name": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Experimental Web Platform Features"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
"flags": [ | ||
{ | ||
"type": "preference", | ||
"name": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dom.fetch.enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
"flags": [ | ||
{ | ||
"type": "preference", | ||
"name": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Experimental Web Platform Features"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
"flags": [ | ||
{ | ||
"type": "preference", | ||
"name": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Experimental Web Platform Features"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
api/Headers.json
Outdated
"version_added": false | ||
}, | ||
"opera": { | ||
"version_added": "29" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"opera": [
{
"version_added": "29"
},
{
"version_added": "28",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
],
"opera_android": [
{
"version_added": "29"
},
{
"version_added": "28",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This one is a little odd as it contains an entry for both "
getAll()
removed" (see the table herehttps://developer.mozilla.org/en-US/docs/Web/API/Headers) and
getAll()
. I'm pretty sure the former is redundant - but am leaving it in just in case.