Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the autocorrect attribute as standard #35593

Closed
annevk opened this issue Aug 26, 2024 · 4 comments
Closed

Define the autocorrect attribute as standard #35593

annevk opened this issue Aug 26, 2024 · 4 comments
Assignees
Labels
Content:HTML Hypertext Markup Language docs

Comments

@annevk
Copy link
Contributor

annevk commented Aug 26, 2024

It's being added to HTML in whatwg/html#5841 and is already implemented by Chrome and Safari per comments there. (MDN seems to only list Safari though.)

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Aug 26, 2024
@Josh-Cena Josh-Cena added Content:HTML Hypertext Markup Language docs and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Aug 26, 2024
@hamishwillee hamishwillee self-assigned this Aug 30, 2024
@hamishwillee
Copy link
Collaborator

hamishwillee commented Aug 30, 2024

@annevk I can't see evidence that Chrome actually implemented this in that link - and it doesn't pass the tests https://wpt.live/html/editing/editing-0/autocorrection/autocorrection.html except for "Test autocorrection in an editing host.".

Am I missing something?

PS And safari doesn't pass all the tests either. So we'll need some nuance in the browser compatibility data.

@annevk
Copy link
Contributor Author

annevk commented Aug 30, 2024

I'm not sure. In the HTML PR someone pointed out Chromium code that shows there's an implementation, but perhaps it never shipped. It also wasn't fully compliant.

Safari should soonish ship fully compliant behavior. The failing tests are not something I would expect web developers to run into when using this though. See WebKit/WebKit@28a8a4b for the changes made to WebKit if you're interested.

@hamishwillee
Copy link
Collaborator

Fixed by #35692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

No branches or pull requests

4 participants