-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autocorrect property #24249
autocorrect property #24249
Conversation
26b39be
to
f30d14a
Compare
What is the behavior of autocorrect on passwords? |
@caugner The spec states that autocorrect should not work on passwords. However the safari implementation does act on passwords if this feature is enabled on the input. Note that apparently Safari are moving to a compliant implementation. BTW, thank you for all these reviews. The BCD team are clearly hammered because this has been waiting a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two nits (missing closing parenthesis).
The global autocorrect property was previously Safari-only, but has now become part of the HTML spec. This adds the element and API to BCD.
Testing on browsertack shows that the property starts to appear on HTMLElement from Safari 14.1. Also that contrary to the spec:
There might be other things, but it does seem to otherwise match the spec. I have added as partial implementation.
Part of mdn/content#35593
Fixes #22704