Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocorrect property #24249

Merged
merged 5 commits into from
Oct 7, 2024
Merged

autocorrect property #24249

merged 5 commits into from
Oct 7, 2024

Conversation

hamishwillee
Copy link
Contributor

@hamishwillee hamishwillee commented Aug 30, 2024

The global autocorrect property was previously Safari-only, but has now become part of the HTML spec. This adds the element and API to BCD.

Testing on browsertack shows that the property starts to appear on HTMLElement from Safari 14.1. Also that contrary to the spec:

  • autocorrect works on passwords (it shouldn't)
  • The setter/getter is "true/false" instead of spec "on/off".

There might be other things, but it does seem to otherwise match the spec. I have added as partial implementation.

Part of mdn/content#35593

Fixes #22704

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Aug 30, 2024
@hamishwillee hamishwillee marked this pull request as ready for review September 20, 2024 06:35
@caugner
Copy link
Contributor

caugner commented Oct 2, 2024

  • autocorrect works on passwords

What is the behavior of autocorrect on passwords?

api/HTMLElement.json Outdated Show resolved Hide resolved
@hamishwillee
Copy link
Contributor Author

  • autocorrect works on passwords

What is the behavior of autocorrect on passwords?

@caugner The spec states that autocorrect should not work on passwords. However the safari implementation does act on passwords if this feature is enabled on the input.

Note that apparently Safari are moving to a compliant implementation.

BTW, thank you for all these reviews. The BCD team are clearly hammered because this has been waiting a while.

@hamishwillee hamishwillee requested a review from caugner October 3, 2024 23:07
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two nits (missing closing parenthesis).

api/HTMLElement.json Outdated Show resolved Hide resolved
html/global_attributes.json Outdated Show resolved Hide resolved
@caugner caugner enabled auto-merge (squash) October 7, 2024 09:17
@caugner caugner disabled auto-merge October 7, 2024 09:17
@caugner caugner merged commit 0376871 into mdn:main Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html.elements.textarea - autocorrect browser compatibility not listed
2 participants