Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InheritanceDiagram to some WebXR event pages #11025

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 7, 2021

@Elchi3 Elchi3 requested a review from a team December 7, 2021 10:25
@Elchi3 Elchi3 requested a review from a team as a code owner December 7, 2021 10:25
@Elchi3 Elchi3 requested review from fiji-flo and Rumyra and removed request for a team December 7, 2021 10:25
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/XRSession/selectend_event
Title: XRSession: selectend event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSession/squeezeend_event
Title: XRSession: squeezeend event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSession/inputsourceschange_event
Title: XRSession: inputsourceschange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSession/squeezestart_event
Title: XRSession: squeezestart event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSession/select_event
Title: XRSession: select event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSession/squeeze_event
Title: XRSession: squeeze event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSession/end_event
Title: XRSession: end event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSession/selectstart_event
Title: XRSession: selectstart event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSession/visibilitychange_event
Title: XRSession: visibilitychange event
on GitHub

No new external URLs

(this comment was updated 2022-01-13 15:38:55.469179)

@ddbeck
Copy link
Contributor

ddbeck commented Dec 7, 2021

I like it with the text alongside. 👍

@jpmedley
Copy link
Collaborator

jpmedley commented Dec 7, 2021

I like this proposal. I'm happy to merge for you if we have consensus.

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 8, 2021

Rebased to not update inheritance data here. I merged #8797 instead.

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 8, 2021

I like this proposal. I'm happy to merge for you if we have consensus.

It seems this proposal has indeed consensus. At least I haven't heard otherwise.

@Rumyra
Copy link
Collaborator

Rumyra commented Dec 8, 2021

Yeh I'm into it! Looks good @Elchi3 👍

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 10, 2021

mdn/yari#5056 will make this a lot better and avoid the weird sizing parameters. Converting to draft for the moment.

@Elchi3 Elchi3 marked this pull request as draft December 10, 2021 12:32
@Elchi3 Elchi3 force-pushed the events-inheritance branch from 096858f to 0352150 Compare January 13, 2022 15:36
@Elchi3 Elchi3 marked this pull request as ready for review January 13, 2022 15:38
@Elchi3
Copy link
Member Author

Elchi3 commented Jan 13, 2022

mdn/yari#5056 landed so this PR works nicely now :)

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 14, 2022

So we're good to go @Elchi3 ?

@Elchi3
Copy link
Member Author

Elchi3 commented Jan 14, 2022

@Rumyra Yes we are :)

@Rumyra Rumyra merged commit a139ade into mdn:main Jan 19, 2022
@Elchi3 Elchi3 deleted the events-inheritance branch January 19, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants