Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MediaStreamTrackAudioSourceOptions from MDN #11297

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Remove MediaStreamTrackAudioSourceOptions from MDN #11297

merged 3 commits into from
Dec 20, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the MediaStreamTrackAudioSourceOptions dictionary from MDN. It's solely used for the MediaStreamTrackAudioSourceNode constructor, so there's not much of a point in keeping a separate page. Correlates with its removal in BCD, see mdn/browser-compat-data#14072.

@queengooborg queengooborg requested review from a team as code owners December 18, 2021 15:59
@queengooborg queengooborg requested review from ddbeck and jpmedley and removed request for a team December 18, 2021 15:59
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 18, 2021
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/MediaStreamTrackAudioSourceNode/MediaStreamTrackAudioSourceNode
Title: MediaStreamTrackAudioSourceNode()
on GitHub

No new external URLs

hamishwillee
hamishwillee approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @queengooborg , much appreciated.

@hamishwillee hamishwillee merged commit a191865 into mdn:main Dec 20, 2021
@queengooborg queengooborg deleted the MediaStreamTrackAudioSourceOptions branch December 20, 2021 04:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@ddbeck ddbeck Awaiting requested review from ddbeck ddbeck is a code owner automatically assigned from mdn/yari-content-mdn

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @hamishwillee