Issue/12834 Fix Content Negotiation Blurry Text In Diagram #12856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoli2003
suggested changes
Feb 9, 2022
hh-shiung
force-pushed
the
Issue/12834-fix-content-negotiation-blurry-text-in-diagram
branch
from
5f816f6 to
a30a9d9
Compare
hh-shiung
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
hh-shiung
force-pushed
the
Issue/12834-fix-content-negotiation-blurry-text-in-diagram
branch
from
18a25b1 to
f6c360f
Compare
hh-shiung
force-pushed
the
Issue/12834-fix-content-negotiation-blurry-text-in-diagram
branch
from
f6c360f to
6ea714a
Compare
|
Thanks for the catch! Did some fiddling to clean up git history, but now it should be one commit for the correct image. |
teoli2003
suggested changes
Feb 9, 2022
|
It was my mistake, I skipped reading the image protocol. Updated with a compressed image that should passed tests. |
teoli2003
approved these changes
Feb 9, 2022
|
Thanks a lot! Looks good to me. Congratulations upon your first merged commit here! Welcome aboard! 🎉 |
hh-shiung
deleted the
Issue/12834-fix-content-negotiation-blurry-text-in-diagram
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Redrew diagram for Content Negotiation to fix blurry text with previous image.
Motivation
The image clarity should be an improvement over the old image. Bad images strains eyeballs.
Supporting details
Related issues
Fixes #12834
Metadata
This PR