Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect that has a // in it #12866

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix redirect that has a // in it #12866

merged 1 commit into from
Feb 9, 2022

Conversation

teoli2003
Copy link
Contributor

I double pressed / so the redirection URL has a // in it.

This has no impact, but let's keep this clean. Follow-up of #12851.

@teoli2003 teoli2003 requested a review from Elchi3 February 9, 2022 15:06
@teoli2003 teoli2003 requested a review from a team as a code owner February 9, 2022 15:06
Elchi3
Elchi3 approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought Yari's redirect validator is quite strict, but I guess it didn't catch this because in theory it is a valid URL as you say.

@Elchi3 Elchi3 merged commit 058645f into mdn:main Feb 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @Elchi3