-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt api.RTCDTMFSender.ontonechange to new events structure #13594
Conversation
This PR adapts the tonechange event of the RTCDTMFSender API to conform to the new events structure.
Preview URLs
FlawsNote! 3 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
External URLsURL: URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2022-03-08 14:41:53.628135) |
[REVIEW IN PROGRESS] Checklist I used for reviewing this event Content PR: When
On the API interface page:
On each page of the interface and the API overview page:
Optional:
Administration:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another small thing to fix:
- In
insertDTMF()
there is an `{{event("tonechange")}} to change.
This still need to be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I even missed the others!
This PR adapts the tonechange event of the RTCDTMFSender API to conform to the new events structure.
BCD PR: mdn/browser-compat-data#15188