Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt RTCDataChannel API to new events structure #13894

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Adapt RTCDataChannel API to new events structure #13894

merged 4 commits into from
Mar 23, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the RTCDataChannel API to conform to the new events structure.

BCD PR: mdn/browser-compat-data#15189

@queengooborg
Adapt RTCDataChannel API to new events structure
770932d 
This PR adapts the RTCDataChannel API to conform to the new events structure.
@queengooborg queengooborg requested review from a team as code owners March 15, 2022 11:21
@queengooborg queengooborg requested review from jpmedley and Rumyra and removed request for a team March 15, 2022 11:21
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub
Flaw count: 24

  • macros:
    • /en-US/docs/Web/CSS/-moz-math-display does not exist
    • /en-US/docs/Web/CSS/-moz-window-shadow does not exist
    • /en-US/docs/Web/CSS/@page/marks does not exist
    • /en-US/docs/Web/CSS/page does not exist
    • /en-US/docs/Web/CSS/size does not exist
    • and 11 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Tools/Memory
    • Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Work_with_animations
    • Can't resolve /en-US/docs/Tools/Performance/Waterfall#markers
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Firefox_for_Android/API/Snackbars.jsm
    • Can't resolve /en-US/docs/Mozilla/Firefox_for_Android
    • and 3 more flaws omitted

URL: /en-US/docs/Web/API/RTCError
Title: RTCError
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/RTCError/RTCError does not exist

URL: /en-US/docs/Web/API/RTCDataChannel
Title: RTCDataChannel
on GitHub
Flaw count: 6

  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/RTCDataChannel/message_event
Title: RTCDataChannel: message event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/WindowProxy does not exist

URL: /en-US/docs/Web/API/RTCDataChannel/closing_event
Title: RTCDataChannel: closing event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.RTCDataChannel.closing_event

URL: /en-US/docs/Web/API/MessageEvent
Title: MessageEvent
on GitHub
Flaw count: 8

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/EventSource/onmessage redirects to /en-US/docs/Web/API/EventSource/message_event
    • /en-US/docs/Web/API/Window/onmessage does not exist
    • /en-US/docs/Web/API/BroadcastChannel/onmessage redirects to /en-US/docs/Web/API/BroadcastChannel/message_event
    • and 2 more flaws omitted
  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCError
Title: RTCError
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel
Title: RTCDataChannel
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/open_event
Title: RTCDataChannel: open event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/close_event
Title: RTCDataChannel: close event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/bufferedAmount
Title: RTCDataChannel.bufferedAmount
on GitHub

No external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/bufferedAmountLowThreshold
Title: RTCDataChannel.bufferedAmountLowThreshold
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/message_event
Title: RTCDataChannel: message event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/closing_event
Title: RTCDataChannel: closing event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/bufferedamountlow_event
Title: RTCDataChannel: bufferedamountlow event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/error_event
Title: RTCDataChannel: error event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCErrorEvent/error
Title: RTCErrorEvent.error
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MessageEvent
Title: MessageEvent
on GitHub

No new external URLs

(this comment was updated 2022-03-23 11:00:06.884162)

@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Mar 15, 2022
jpmedley
jpmedley previously requested changes Mar 15, 2022
View reviewed changes
@queengooborg queengooborg requested a review from jpmedley March 17, 2022 07:17
jen801
jen801 reviewed Mar 18, 2022
View reviewed changes
Copy link

@jen801 jen801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files/en-us/web/api/rtcdatachannel/message_event/index.md

@Elchi3 Elchi3 dismissed jpmedley’s stale review March 23, 2022 11:00

feedback addressed

@Elchi3 Elchi3 merged commit 34b5c4c into mdn:main Mar 23, 2022
@queengooborg queengooborg deleted the api/RTCDataChannel/events branch March 23, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen801 jen801 jen801 left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

@teoli2003 teoli2003 teoli2003 approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra is a code owner automatically assigned from mdn/yari-content-mdn

@jpmedley jpmedley Awaiting requested review from jpmedley

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@queengooborg @Elchi3 @teoli2003 @jpmedley @jen801